Skip to content

Fixes: Circle CI and Docker build failing due to unupdated version of node #6397

Merged
ramyaragupathy merged 2 commits into
developfrom
infra-node-18-version
May 1, 2024
Merged

Fixes: Circle CI and Docker build failing due to unupdated version of node #6397
ramyaragupathy merged 2 commits into
developfrom
infra-node-18-version

Conversation

@mahesh-naxa
Copy link
Copy Markdown
Contributor

@mahesh-naxa mahesh-naxa commented May 1, 2024

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🧑‍💻 Refactor
  • ✅ Test
  • 🤖 Build or CI
  • ❓ Other (please specify)

Related Issue

Fixes the frontend tests failing issue on #6375 & develop branch.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mahesh-naxa
Copy link
Copy Markdown
Contributor Author

The tests seems to be working with the latest circleci image cimg/node:18.19.1.

However i am not sure why the image cimg/python:3.10.7-node was choosen for the deploy steps, I have replaced those with the cimg/node:18.19.1. If there wasn't a specific need the PR can be safely merged, without breaking the deployment steps.

Just to let you know i did test the install-ability these:

  • libgeos-dev jq aws-cli
  • @mapbox/cfn-config @mapbox/cloudfriend

- image: cimg/python:3.10.7-node

- image: cimg/python:3.10.7-node

(maybe just merging this and testing if the deployment works straight to our develop also could be wise @ramyaragupathy )
cc @eternaltyro @dakotabenjamin

@dakotabenjamin
Copy link
Copy Markdown
Member

I think the reasoning was frontend uses node and backend uses python. If the node image contains a fixed version of python then it's all good to me IMO.

@dakotabenjamin dakotabenjamin self-requested a review May 1, 2024 13:24
@ramyaragupathy ramyaragupathy merged commit 2a53bcc into develop May 1, 2024
@ramyaragupathy ramyaragupathy added this to the v4.7.2 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants