Skip to content

Handle missing CRL distribution points in revocation check fallback #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BernhardK91 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle missing CRL distribution points in revocation check fallback #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...odeckb2b-certmanager/src/main/java/org/holodeckb2b/security/trust/DefaultCertManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,11 +571,15 @@ public IValidationResult validateCertificate(List<X509Certificate> certs, IValid
Utils.getExceptionTrace(validationException));

// If reason is "unspecified" or "undetermined" this could indicate either that the certificate is not
// valid, or that there was a problem in executing the OCSP check. In the latter case, try again without
// valid, or that there was a problem in executing the revocation check. In the latter case, try again
// without. This covers OCSP infrastructure issues (IOException cause) and missing CRL distribution
// points (RecoverableCertPathValidatorException with "No CRLs found" message).
if (performRevocationCheck
&& (reason == BasicReason.UNDETERMINED_REVOCATION_STATUS
|| (reason == BasicReason.UNSPECIFIED && validationException.getCause() != null
&& (validationException.getCause() instanceof IOException)))) {
&& (validationException.getCause() instanceof IOException))
|| (reason == BasicReason.UNSPECIFIED && validationException.getMessage() != null
&& validationException.getMessage().contains("No CRLs found")))) {
try {
log.debug("Validation with revocation check failed ({}), retry without",
validationException.getMessage());
Expand Down