Handle missing CRL distribution points in revocation check fallback#176
Open
BernhardK91 wants to merge 1 commit into
Open
Handle missing CRL distribution points in revocation check fallback#176BernhardK91 wants to merge 1 commit into
BernhardK91 wants to merge 1 commit into
Conversation
When BouncyCastle PKIX validates a certificate chain with revocation checking enabled, it fails with UNSPECIFIED reason and "No CRLs found for issuer" if the issuing CA does not provide CRL distribution points. This is common for intermediates signed by root CAs (e.g. Google Trust Services WE1 signed by GTS Root R4). The existing fallback only retried without revocation for UNDETERMINED_REVOCATION_STATUS or UNSPECIFIED with an IOException cause. The "No CRLs found" error uses a RecoverableCertPathValidatorException (not IOException), so the fallback was not triggered. Add a message-based check for "No CRLs found" to also retry without revocation checking in this case.
Collaborator
|
Hi @BernhardK91, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When BouncyCastle PKIX validates a certificate chain with revocation checking enabled, it fails with UNSPECIFIED reason and "No CRLs found for issuer" if the issuing CA does not provide CRL distribution points. This is common for intermediates signed by root CAs (e.g. Google Trust Services WE1 signed by GTS Root R4).
The existing fallback only retried without revocation for UNDETERMINED_REVOCATION_STATUS or UNSPECIFIED with an IOException cause. The "No CRLs found" error uses a RecoverableCertPathValidatorException (not IOException), so the fallback was not triggered.
This adds a message-based check for "No CRLs found" to also retry without revocation checking in this case.