Skip to content

[V4] Add endpoint for editing comments #14523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattsoh wants to merge 6 commits into
base: main
Choose a base branch
from
+237 −1
Open

[V4] Add endpoint for editing comments #14523

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0fdcaa3
add endpoint to edit comments
mattsoh Aug 6, 2026
274b9ae
remove ability to add/change file when editing comment
mattsoh Aug 6, 2026
4632577
gatekeep admin only behind auditor access
mattsoh Aug 8, 2026
99af44e
add v4 comments api tests
mattsoh Aug 8, 2026
fa05fbe
Merge branch 'main' into mattsoh-api-comments-edit
mattsoh Aug 8, 2026
d9446f6
re-add newline
mattsoh Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/controllers/api/v4/comments_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ def create

require_oauth2_scope "comments:write", :create

def update
@comment = authorize Comment.find_by_public_id!(params[:id])

@comment.update!(params.permit(:content, :admin_only))

@garyhtou garyhtou Aug 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please write tests for this?

  • When admin_only is omitted, it doesn't change admin_only in the DB
    • make sure to the case where it start as admin_only = true
  • When admin_only is a non-boolean (e.g. string or integer), what do we do?

@mattsoh mattsoh Aug 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When admin_only is a non-boolean, the values are coerced (when running @comment.update!). This is the same logic as in creating comments (except admin_only is by default set to false when creating comments - if no admin_only value is provided in the API call we don't change anything).


render "show"
end

require_oauth2_scope "comments:write", :update

end
end
end
2 changes: 1 addition & 1 deletion config/routes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,7 +820,7 @@
resources :wires, only: [:index, :show, :create]
resources :ach_transfers, only: [:create]

resources :comments, only: [:index, :create]
resources :comments, only: [:index, :create, :update]

get "stripe_terminal_connection_token", to: "stripe_terminal#connection_token"

Expand Down