[V4] Add endpoint for editing comments - #14523
Open
mattsoh wants to merge 2 commits into
Open
Conversation
garyhtou
reviewed
Aug 7, 2026
| def update | ||
| @comment = authorize Comment.find_by_public_id!(params[:id]) | ||
|
|
||
| @comment.update!(params.permit(:content, :admin_only)) |
Member
There was a problem hiding this comment.
Can you please write tests for this?
- When
admin_onlyis omitted, it doesn't changeadmin_onlyin the DB- make sure to the case where it start as
admin_only = true
- make sure to the case where it start as
- When
admin_onlyis a non-boolean (e.g. string or integer), what do we do?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the problem
Add ability to edit comments on V4 Api. This helps for Steelyard, and maybe HCB mobile?
Describe your changes
Added endpoint (content and admin_only).