Skip to content

Fix TypeScript typing for flat config in eslint-plugin-react-hooks #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
everettbu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix TypeScript typing for flat config in eslint-plugin-react-hooks #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions packages/eslint-plugin-react-hooks/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
import type {Linter, Rule} from 'eslint';
import type { Linter, Rule } from 'eslint';

import ExhaustiveDeps from './rules/ExhaustiveDeps';
import {
Expand Down Expand Up @@ -50,15 +50,18 @@ const recommendedRuleConfigs: Linter.RulesRecord = {
...basicRuleConfigs,
...recommendedCompilerRuleConfigs,
};

const recommendedLatestRuleConfigs: Linter.RulesRecord = {
...basicRuleConfigs,
...recommendedLatestCompilerRuleConfigs,
};

const plugins = ['react-hooks'];
const plugins = ['react-hooks'] as const;

type ReactHooksFlatConfig = {
plugins: {react: any};
plugins: {
'react-hooks': unknown;
};
rules: Linter.RulesRecord;
};

Expand Down Expand Up @@ -88,11 +91,11 @@ const plugin = {

Object.assign(configs.flat, {
'recommended-latest': {
plugins: {'react-hooks': plugin},
plugins: { 'react-hooks': plugin },
rules: configs['recommended-latest'].rules,
},
recommended: {
plugins: {'react-hooks': plugin},
plugins: { 'react-hooks': plugin },
rules: configs.recommended.rules,
},
});
Expand Down
Loading