Fix TypeScript typing for flat config in eslint-plugin-react-hooks#694
Open
Fix TypeScript typing for flat config in eslint-plugin-react-hooks#694
Conversation
Greptile SummaryThis PR is a type-only correction to
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 621ea1c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of facebook/react#36017
Original author: anasahhm
Fixes #36016
The
ReactHooksFlatConfigtype defined thepluginsproperty as{ react: any },while the actual runtime configuration uses the key
'react-hooks'.This mismatch causes incorrect TypeScript inference when using
configs.flat.recommendedin ESLint flat configuration with TypeScript strict mode.This change updates the
ReactHooksFlatConfigtype so that thepluginsproperty correctly reflects the plugin key
'react-hooks'.No runtime behaviour is changed.
This is a type-only correction to align
the TypeScript definition with the actual configuration object.