Skip to content

Fix #962 - use the title for the jUnit test case name #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manarth wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix #962 - use the title for the jUnit test case name #1035

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29213b6
Fix #962 - use the title for the jUnit test case name
manarth Sep 6, 2025
20333ca
Escape the test-case title provided in the config.
manarth Sep 6, 2025
2463efb
Refactor to use Sprintf for readabilitly.
manarth Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions outputs/junit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,18 @@ func (r JUnit) Output(w io.Writer, results <-chan []resource.TestResult,
endTime = testResult.EndTime
}
duration := strconv.FormatFloat(testResult.Duration.Seconds(), 'f', 3, 64)
summary[testCount] = "<testcase name=\"" +
testResult.ResourceType + " " +
escapeString(testResult.ResourceId) + " " +
testResult.Property + "\" " +
"time=\"" + duration + "\">\n"
testcaseName := fmt.Sprintf("%s %s %s",

@kgaughan kgaughan Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you're mixing spaces and tabs, and have a number of unnecessary semicolons. Could you run go fmt over the file?

testResult.ResourceType,
escapeString(testResult.ResourceId),

@kgaughan kgaughan Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could instead just escape once when building <testcase>.

Suggested change
escapeString(testResult.ResourceId),
testResult.ResourceId,

testResult.Property);
if (testResult.Title != "") {
testcaseName = escapeString(testResult.Title);

@kgaughan kgaughan Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
testcaseName = escapeString(testResult.Title);
testcaseName = testResult.Title

}
summary[testCount] = fmt.Sprintf("<testcase name=\"%s\" time=\"%s\">\n",
testcaseName,

@kgaughan kgaughan Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
testcaseName,
escapeString(testcaseName),

duration,
);

if testResult.Result == resource.FAIL {
summary[testCount] += "<system-err>" +
escapeString(humanizeResult(testResult, true, includeRaw)) +
Expand Down