Fix #962 - use the title for the jUnit test case name - #1035
Open
manarth wants to merge 3 commits into
Open
Conversation
kgaughan
reviewed
Jun 29, 2026
kgaughan
left a comment
kgaughan
left a comment
Collaborator
There was a problem hiding this comment.
Some suggestions. Also, could you merge from master and run the test suite to make sure there are no issues this change might cause?
| escapeString(testResult.ResourceId) + " " + | ||
| testResult.Property + "\" " + | ||
| "time=\"" + duration + "\">\n" | ||
| testcaseName := fmt.Sprintf("%s %s %s", |
Collaborator
There was a problem hiding this comment.
It looks like you're mixing spaces and tabs, and have a number of unnecessary semicolons. Could you run go fmt over the file?
| "time=\"" + duration + "\">\n" | ||
| testcaseName := fmt.Sprintf("%s %s %s", | ||
| testResult.ResourceType, | ||
| escapeString(testResult.ResourceId), |
Collaborator
There was a problem hiding this comment.
You could instead just escape once when building <testcase>.
Suggested change
| escapeString(testResult.ResourceId), | |
| testResult.ResourceId, |
| escapeString(testResult.ResourceId), | ||
| testResult.Property); | ||
| if (testResult.Title != "") { | ||
| testcaseName = escapeString(testResult.Title); |
Collaborator
There was a problem hiding this comment.
Suggested change
| testcaseName = escapeString(testResult.Title); | |
| testcaseName = testResult.Title |
| testcaseName = escapeString(testResult.Title); | ||
| } | ||
| summary[testCount] = fmt.Sprintf("<testcase name=\"%s\" time=\"%s\">\n", | ||
| testcaseName, |
Collaborator
There was a problem hiding this comment.
Suggested change
| testcaseName, | |
| escapeString(testcaseName), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Fix #962
This checks for the presence of a "title" attribute on the test-case, and uses that in the jUnit report if it is present.
Checklist
make test-all(UNIX) passes. CI will also test this