Skip to content

fix(webhook): normalize endpoint URL before validation #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PrasunaEnumarthy wants to merge 5 commits into
base: main
Choose a base branch
from
+88 −2
Open

fix(webhook): normalize endpoint URL before validation #800

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
964bdc2
fix(webhook): normalize endpoint URL before validation
PrasunaEnumarthy Apr 5, 2026
ede18ed
test(webhook): add coverage for endpoint URL normalization
PrasunaEnumarthy Apr 8, 2026
531c013
test(webhook): add header to webhook tests
PrasunaEnumarthy Apr 8, 2026
4afeb5d
test(webhook): cover invalid endpoint validation path
PrasunaEnumarthy Apr 8, 2026
bd6840e
Merge branch 'main' of https://github.com/goharbor/harbor-cli into fi…
PrasunaEnumarthy Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmd/harbor/root/webhook/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,12 @@ or leave them out and be guided through an interactive prompt to input each fiel
opts.NotifyType != "" &&
len(opts.EventType) != 0 &&
opts.EndpointURL != "" {
err = utils.ValidateURL(opts.EndpointURL)
formattedURL := utils.FormatUrl(opts.EndpointURL)
err = utils.ValidateURL(formattedURL)
if err != nil {
return err
}
opts.EndpointURL = formattedURL
err = api.CreateWebhook(&opts)
} else {
err = createWebhookView(createView)
Expand Down
5 changes: 4 additions & 1 deletion cmd/harbor/root/webhook/edit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,13 @@ or leave them out and use the interactive prompt to select and update a webhook.
opts.NotifyType != "" &&
len(opts.EventType) != 0 &&
opts.EndpointURL != "" {
if err := utils.ValidateURL(opts.EndpointURL); err != nil {
formattedURL := utils.FormatUrl(opts.EndpointURL)
if err := utils.ValidateURL(formattedURL); err != nil {
return err
}
opts.EndpointURL = formattedURL
err = api.UpdateWebhook(&opts)

} else {
err = editWebhookView(editView)
}
Expand Down
Loading