Skip to content

web: Fix table visibility checks, search params.#21623

Open
GirlBossRush wants to merge 1 commit intomainfrom
fix-modal-visibility-checks
Open

web: Fix table visibility checks, search params.#21623
GirlBossRush wants to merge 1 commit intomainfrom
fix-modal-visibility-checks

Conversation

@GirlBossRush
Copy link
Copy Markdown
Contributor

@GirlBossRush GirlBossRush commented Apr 15, 2026

Details

This PR fixes a regression introduced in the modals clean up. Interactivity checks now handle tables outside of modals, allowing search params to synchronizing to the URL.

@GirlBossRush GirlBossRush self-assigned this Apr 15, 2026
@GirlBossRush GirlBossRush requested a review from a team as a code owner April 15, 2026 14:50
@GirlBossRush GirlBossRush added the area:frontend Features or issues related to the browser, TypeScript, Node.js, etc label Apr 15, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 15, 2026

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 524d7c8
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/69dfa5d2d4b17c00083f79b4
😎 Deploy Preview https://deploy-preview-21623--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 15, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 524d7c8
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/69dfa5d2281e0100086b1b87
😎 Deploy Preview https://deploy-preview-21623--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (668f37e) to head (524d7c8).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21623      +/-   ##
==========================================
- Coverage   92.29%   92.25%   -0.05%     
==========================================
  Files        1032     1032              
  Lines       59767    59767              
  Branches     2537     2537              
==========================================
- Hits        55162    55137      -25     
- Misses       4540     4567      +27     
+ Partials       65       63       -2     
Flag Coverage Δ
conformance 36.98% <ø> (+<0.01%) ⬆️
e2e 42.89% <ø> (-0.01%) ⬇️
integration 33.39% <ø> (-0.52%) ⬇️
rust 60.58% <ø> (+0.07%) ⬆️
unit 91.92% <ø> (ø)
unit-migrate 92.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-524d7c81fa20130fda7ba04f8fbdf3245c55ca5c
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-524d7c81fa20130fda7ba04f8fbdf3245c55ca5c

Afterwards, run the upgrade commands from the latest release notes.

Copy link
Copy Markdown
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice re-org.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in authentik Core Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend Features or issues related to the browser, TypeScript, Node.js, etc

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants