Skip to content

web: follow-up polish for modal and form components#21588

Closed
GirlBossRush wants to merge 0 commit intomainfrom
modal-revisions-4
Closed

web: follow-up polish for modal and form components#21588
GirlBossRush wants to merge 0 commit intomainfrom
modal-revisions-4

Conversation

@GirlBossRush
Copy link
Copy Markdown
Contributor

@GirlBossRush GirlBossRush commented Apr 14, 2026

Dependencies

Follow-up to #21336 — small fixes and polish that came out of testing the modal revisions.

Summary

  • Add scroll shadow utility class for scrollable containers (dialog body, sidebar)
  • Tidy FormGroup marker styles with CSS custom properties
  • Wire up ApplicationCheckAccessForm with modalInvoker
  • Move clearSearch to base Table class, fix isInteractiveElement tabIndex handling
  • Add neutral state to ak-status-label

Breakdown

  1. de2cbf03f1 CSS/styling: logical properties for dialogs, scroll shadow utility, radio/form control rework, FormGroup marker refactor, sidebar padding fix
  2. a1e07176f0 Elements/components: dialog ARIA, tri-state status label, FormGroup simplification, LogViewer/StaticTable cleanup, switch/radio input fixes
  3. d9a0cb7264 Application pages: modalInvoker migration, form metadata properties, nullable createPaginatedResponse, dropdown casing fix

Test plan

  • Modals scroll correctly with shadow hints at overflow boundaries
  • FormGroup expand/collapse markers render in both themes
  • "Check access" and "Edit" on Application view page open correctly
  • Table search clear works from both TablePage and StaticTable contexts

@GirlBossRush GirlBossRush requested a review from a team as a code owner April 14, 2026 03:55
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 14, 2026

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit 6d57854
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/69e86b612b2fa80008745420
😎 Deploy Preview https://deploy-preview-21588--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@GirlBossRush GirlBossRush requested a review from BeryJu April 14, 2026 03:56
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 14, 2026

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 6d57854
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/69e86b61db70670008144e0c
😎 Deploy Preview https://deploy-preview-21588--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@GirlBossRush GirlBossRush added the area:frontend Features or issues related to the browser, TypeScript, Node.js, etc label Apr 14, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 14, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 6d57854
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/69e86b61b3c07500081a68bd
😎 Deploy Preview https://deploy-preview-21588--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.22%. Comparing base (af747c6) to head (4145dd2).
⚠️ Report is 13 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21588      +/-   ##
==========================================
- Coverage   92.29%   92.22%   -0.08%     
==========================================
  Files        1032     1033       +1     
  Lines       59767    59947     +180     
  Branches     2537     2695     +158     
==========================================
+ Hits        55163    55286     +123     
- Misses       4541     4588      +47     
- Partials       63       73      +10     
Flag Coverage Δ
conformance 36.97% <ø> (-0.01%) ⬇️
e2e 42.89% <ø> (-0.01%) ⬇️
integration 33.89% <ø> (-0.01%) ⬇️
rust 60.55% <ø> (-0.03%) ⬇️
unit 91.92% <ø> (+<0.01%) ⬆️
unit-migrate 92.02% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 14, 2026

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-4145dd2c1c195204e161affed1ffccf0beb6619f
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-4145dd2c1c195204e161affed1ffccf0beb6619f

Afterwards, run the upgrade commands from the latest release notes.

@GirlBossRush
Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

@GirlBossRush GirlBossRush force-pushed the modal-revisions-4 branch 3 times, most recently from 65fd887 to db0121b Compare April 15, 2026 16:48
@github-project-automation github-project-automation Bot moved this from Todo to Done in authentik Core Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend Features or issues related to the browser, TypeScript, Node.js, etc

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant