Skip to content

web: migrate remaining view pages to modalInvoker#21592

Open
GirlBossRush wants to merge 12 commits intomodal-revisions-4from
modal-revisions-5
Open

web: migrate remaining view pages to modalInvoker#21592
GirlBossRush wants to merge 12 commits intomodal-revisions-4from
modal-revisions-5

Conversation

@GirlBossRush
Copy link
Copy Markdown
Contributor

Follow-up to #21336 and #21588 — migrates the remaining view/detail pages still using ak-forms-modal to the modalInvoker directive.

Summary

  • Migrate edit buttons on device, flow, group, role, provider (OAuth2, SSF), and source (LDAP, OAuth) view pages to modalInvoker
  • Migrate RelatedGroupList toolbar and row actions (add to group, create group, edit group)
  • Add verboseName static properties to EndpointDeviceForm, BaseSourceForm, and RelatedGroupAdd
  • Improve accessibility labels on user list page
  • Add e2e tests for edit flows on role and group view pages, and the related group list modal

Test plan

  • Edit buttons on all migrated view pages open the correct dialog with pre-filled data
  • RelatedGroupList "Add to existing group", "Add new group", and row edit all open correctly
  • New e2e tests pass: role view page edit, group view page edit, related group list add

@GirlBossRush GirlBossRush requested a review from a team as a code owner April 14, 2026 04:52
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 14, 2026

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 4e4b102
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/69ddc81c813fb60008d5f722
😎 Deploy Preview https://deploy-preview-21592--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@GirlBossRush GirlBossRush changed the base branch from main to modal-revisions-4 April 14, 2026 04:53
@GirlBossRush GirlBossRush added the area:frontend Features or issues related to the browser, TypeScript, Node.js, etc label Apr 14, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 14, 2026

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit aeecf99
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/69de742a4db578000889ba7e
😎 Deploy Preview https://deploy-preview-21592--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 14, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit aeecf99
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/69de742a12d98a0008baabc3
😎 Deploy Preview https://deploy-preview-21592--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.22%. Comparing base (fc4f856) to head (4e4b102).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           modal-revisions-4   #21592      +/-   ##
=====================================================
+ Coverage              92.18%   92.22%   +0.04%     
=====================================================
  Files                   1032     1032              
  Lines                  59660    59660              
  Branches                2537     2537              
=====================================================
+ Hits                   54996    55024      +28     
+ Misses                  4601     4573      -28     
  Partials                  63       63              
Flag Coverage Δ
conformance 37.03% <ø> (ø)
e2e 42.95% <ø> (+0.25%) ⬆️
integration 33.44% <ø> (-0.52%) ⬇️
rust 60.58% <ø> (ø)
unit 91.89% <ø> (+<0.01%) ⬆️
unit-migrate 91.99% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend Features or issues related to the browser, TypeScript, Node.js, etc

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant