web: migrate remaining view pages to modalInvoker#21592
Open
GirlBossRush wants to merge 12 commits intomodal-revisions-4from
Open
web: migrate remaining view pages to modalInvoker#21592GirlBossRush wants to merge 12 commits intomodal-revisions-4from
GirlBossRush wants to merge 12 commits intomodal-revisions-4from
Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## modal-revisions-4 #21592 +/- ##
=====================================================
+ Coverage 92.18% 92.22% +0.04%
=====================================================
Files 1032 1032
Lines 59660 59660
Branches 2537 2537
=====================================================
+ Hits 54996 55024 +28
+ Misses 4601 4573 -28
Partials 63 63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fc4f856 to
796cd90
Compare
4e4b102 to
aeecf99
Compare
c2bffaa to
65fd887
Compare
aeecf99 to
7ab39ef
Compare
65fd887 to
db0121b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #21336 and #21588 — migrates the remaining view/detail pages still using
ak-forms-modalto themodalInvokerdirective.Summary
modalInvokerRelatedGroupListtoolbar and row actions (add to group, create group, edit group)verboseNamestatic properties toEndpointDeviceForm,BaseSourceForm, andRelatedGroupAddTest plan