machine: add SetScratchMkfsArgs to allow customising scratch mkfs options#301
Draft
obbardc wants to merge 1 commit into
Draft
machine: add SetScratchMkfsArgs to allow customising scratch mkfs options#301obbardc wants to merge 1 commit into
obbardc wants to merge 1 commit into
Conversation
…ions When the scratch filesystem is backed by a disk image it is formatted with mkfs.ext4 using only default options. Some callers may need to adjust those options. For example, debos builds for 32-bit target architectures need to disable the dir_index feature. Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
Member
|
the scratch filesystem is only meant to be mounted by the vm for |
Member
Author
@sjoerdsimons this was created to fix go-debos/debos#620 along with go-debos/debos#704 The rationale for this change should be in the linked PR and issue. Does it make sense ? Happy to solve this in some other way if we can :-). Possibly better to continue the discussion on the linked PR. |
obbardc
added a commit
to go-debos/debos
that referenced
this pull request
Jun 24, 2026
On 32-bit guests readdir() returns EOVERFLOW when d_off holds an htree hash value with bit 31 set. Disable dir_index on the scratch ext4 filesystem for known 32-bit Debian architectures to avoid this. This depends on fakemachine PR: go-debos/fakemachine#301 Fixes: #620 Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the scratch filesystem is backed by a disk image it is formatted with mkfs.ext4 using only default options. Some callers may need to adjust those options. For example, debos builds for 32-bit target architectures need to disable the dir_index feature.
This is needed by go-debos/debos#704