debos: disable ext4 dir_index on scratch for 32-bit architectures#704
Draft
obbardc wants to merge 2 commits into
Draft
debos: disable ext4 dir_index on scratch for 32-bit architectures#704obbardc wants to merge 2 commits into
obbardc wants to merge 2 commits into
Conversation
Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
On 32-bit guests readdir() returns EOVERFLOW when d_off holds an htree hash value with bit 31 set. Disable dir_index on the scratch ext4 filesystem for known 32-bit Debian architectures to avoid this. This depends on fakemachine PR: go-debos/fakemachine#301 Fixes: #620 Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
obbardc
force-pushed
the
wip/obbardc/fix-scratch-on-32bit
branch
from
a5b453b to
109ec8a
Compare
obbardc
commented
Jun 24, 2026
| if is32BitArch(r.Architecture) { | ||
| // dir_index stores d_off as a hash which can exceed INT32_MAX, | ||
| // causing readdir() to return EOVERFLOW on 32-bit guests. | ||
| m.SetScratchMkfsArgs([]string{"-O", "^dir_index"}) |
Member
Author
There was a problem hiding this comment.
Maybe better to create another method in fakemachine, e.g. m.SetScratchFilesystem32BitCompatible(true|false) (false by default).
so debos becomes e.g.:
if is32BitArch(r.Architecture) {
m.SetScratchFilesystem32BitCompatible(true)
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 32-bit guests readdir() returns EOVERFLOW when d_off holds an htree hash value with bit 31 set. Disable dir_index on the scratch ext4 filesystem for known 32-bit Debian architectures to avoid this.
This depends on fakemachine PR: go-debos/fakemachine#301
Fixes: #620