chore(deps-dev): move vitest and @vitest/coverage-v8 to 5 together - #104
Merged
Conversation
The grouped dependabot PR (#103) could not install. It bumped vitest's range in package.json to ^5.0.0 and moved @vitest/coverage-v8 to 5.0.0 in the lockfile, but left coverage-v8's declared range at ^4.1.1, so npm ci resolved it to 4.1.11 and died on ERESOLVE against the exact peer it pins: While resolving: @vitest/coverage-v8@4.1.11 Found: vitest@5.0.0 peer vitest@"4.1.11" from @vitest/coverage-v8@4.1.11 The group config is already correct -- patterns ["vitest", "@vitest/*"] across all update types -- and recreating the PR reproduced the same split, so this does the manifest bump by hand rather than retrying it a third time. 1669 tests pass across 105 files on vitest 5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #103.
Why by hand
The group config here is already correct —
patterns: ["vitest", "@vitest/*"]across all update types, with a comment explaining exactly this trap. But the grouped PR still could not install:Dependabot bumped
vitestto^5.0.0inpackage.jsonand moved@vitest/coverage-v8to5.0.0in the lockfile, but left coverage-v8's declared range at^4.1.1.npm citherefore resolves coverage-v8 to 4.1.11, which peer-pins the exact vitest it no longer has.I asked dependabot to recreate the PR and it reproduced the identical split, so this does the manifest bump directly rather than retrying a third time.
Change
Both ranges to
^5.0.0inpackage.json, lockfile regenerated.Verification
npm ciclean, 1669 tests pass across 105 files on vitest 5.