Skip to content

UILD-805: Menu bar in search view hidden after saving profile settings #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PBobylev merged 2 commits into from
Apr 28, 2026
Merged

UILD-805: Menu bar in search view hidden after saving profile settings #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f2aa12
Adapt manage profile settings to use the same overflow model as other…
zepheiryan Apr 27, 2026
5063e9f
Update changelog
zepheiryan Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@

## 3.0.0 (IN PROGRESS)
* Fix Sonar issues. Refs [UILD-792].
* Fix for hidden menu bar. Refs [UILD-805].

[UILD-792]:https://folio-org.atlassian.net/browse/UILD-792
[UILD-805]:https://folio-org.atlassian.net/browse/UILD-805

## 2.0.1 (2026-04-23)
* Fix for the case when changes to profile settings are not applied immediately. Fixes [UILD-798].
Expand Down
28 changes: 14 additions & 14 deletions src/App.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,20 +24,6 @@ h6 {
margin: 0;
}

#app-root {
display: flex;
flex-direction: column;
}

.main-content {
flex: 1;
overflow: auto;
}

.no-overflow {
overflow: hidden;
}

#editor-root {
font-family: Inter, system-ui, Avenir, Helvetica, Arial, sans-serif;
line-height: 1.5;
Expand All @@ -54,6 +40,20 @@ h6 {
width: 100%;
}

#app-root {
display: flex;
flex-direction: column;
}

.main-content {
flex: 1;
overflow: auto;
}

.no-overflow {
overflow: hidden;
}

h1 {
font-size: 3.2em;
line-height: 1.1;
Expand Down
2 changes: 1 addition & 1 deletion src/common/constants/routes.constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export const RESOURCE_CREATE_URLS = [ROUTES.RESOURCE_CREATE.uri];

export const MANAGE_PROFILE_SETTINGS_URLS = [ROUTES.MANAGE_PROFILE_SETTINGS.uri];

export const FIXED_HEIGHT_VIEWS = [ROUTES.SEARCH.uri];
export const FIXED_HEIGHT_VIEWS = [ROUTES.SEARCH.uri, ROUTES.MANAGE_PROFILE_SETTINGS.uri];

export enum QueryParams {
Type = 'type',
Expand Down
2 changes: 2 additions & 0 deletions src/views/ManageProfileSettings/ManageProfileSettings.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

.manage-profile-settings {
min-height: 100%;
height: 100%;
overflow-y: auto;
display: flex;
flex-direction: row;
font-size: $font-md;
Expand Down
Loading