Skip to content

UILD-805: Menu bar in search view hidden after saving profile settings#383

Merged
PBobylev merged 2 commits into
masterfrom
UILD-805
Apr 28, 2026
Merged

UILD-805: Menu bar in search view hidden after saving profile settings#383
PBobylev merged 2 commits into
masterfrom
UILD-805

Conversation

@zepheiryan
Copy link
Copy Markdown
Contributor

@zepheiryan zepheiryan commented Apr 27, 2026

https://folio-org.atlassian.net/browse/UILD-805

The issue is caused by having the view use a root parent with main-content class for scrolling. After scrolling within the view and returning to the search view, the scroll position stays the same, but the search view has overflow: hidden, so the menu bar at the top of the page is no longer in the viewport, and all scrolling is disabled, making it invisible and inaccessible. It can't be directly brought back into view by the user (unless they figure out how to focus one of its children).

The bugfix is to fix the manage profile settings view at 100% height and then scroll its own internal content node instead, as other views do.

A few more classes and IDs were brought in under #editor-root to prevent leaking.

… views, scrolling its own internal section instead of main content, making main content hide overflow for this view instead
@github-actions
Copy link
Copy Markdown

Jest Unit Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 5063e9f. ± Comparison against base commit 85de0b3.

@sonarqubecloud
Copy link
Copy Markdown

@PBobylev PBobylev merged commit e31ba42 into master Apr 28, 2026
15 checks passed
@PBobylev PBobylev deleted the UILD-805 branch April 28, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants