Skip to content

fix(build): Fix absl required by s2geometry not resolved #17225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhztheplayer wants to merge 2 commits into from
Closed

fix(build): Fix absl required by s2geometry not resolved #17225

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
110ae41
fix(build): absl required by s2geometry not resolved
zhztheplayer Apr 17, 2026
37fb0ba
address comment
zhztheplayer Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,6 +763,10 @@ if(VELOX_ENABLE_GEO)
endif()

if(VELOX_ENABLE_GEO)
if(NOT TARGET absl::base)
Copy link
Copy Markdown
Contributor

@pratikpugalia pratikpugalia Apr 17, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, Can you move this to s2geometry.cmake instead. For readability it makes sense for any transitive dependency resolution to reside within s2geometry's own cmake file.

velox_set_source(absl)
velox_resolve_dependency(absl)
endif()
list(PREPEND CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/CMake/resolve_dependency_modules/s2geometry)
velox_set_source(s2geometry)
velox_resolve_dependency(s2geometry)
Expand Down
Loading