fix(build): Fix absl required by s2geometry not resolved#17225
Closed
zhztheplayer wants to merge 2 commits intofacebookincubator:mainfrom
Closed
fix(build): Fix absl required by s2geometry not resolved#17225zhztheplayer wants to merge 2 commits intofacebookincubator:mainfrom
zhztheplayer wants to merge 2 commits intofacebookincubator:mainfrom
Conversation
Fixes build error:
```
CMake Error at build/_deps/s2geometry-src/CMakeLists.txt:54 (find_package):
By not providing "Findabsl.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "absl", but
CMake did not find one.
Could not find a package configuration file provided by "absl" with any of
the following names:
abslConfig.cmake
absl-config.cmake
Add the installation prefix of "absl" to CMAKE_PREFIX_PATH or set
"absl_DIR" to a directory containing one of the above files. If "absl"
provides a separate development package or SDK, be sure it has been
installed.
```
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
Bot
added
the
CLA Signed
zhztheplayer
changed the title
Collaborator
Author
Build Impact AnalysisNo build targets affected by this change. Slow path • Graph generated from PR branch |
Contributor
|
@pratikpugalia Pratik, would you help review this fix? |
| endif() | ||
|
|
||
| if(VELOX_ENABLE_GEO) | ||
| if(NOT TARGET absl::base) |
Contributor
There was a problem hiding this comment.
This looks good, Can you move this to s2geometry.cmake instead. For readability it makes sense for any transitive dependency resolution to reside within s2geometry's own cmake file.
pratikpugalia
approved these changes
Apr 18, 2026
pratikpugalia
added
the
ready-to-merge
|
@peterenescu has imported this pull request. If you are a Meta employee, you can view this in D101581081. |
zhztheplayer
added a commit
to IBM/velox
that referenced
this pull request
Apr 20, 2026
zhztheplayer
added a commit
to IBM/velox
that referenced
this pull request
Apr 20, 2026
|
@peterenescu merged this pull request in ab3eea6. |
shrshi
pushed a commit
to patdevinwilson/velox
that referenced
this pull request
Apr 23, 2026
…ubator#17225) Summary: After PR facebookincubator#15511, Velox + GEO now requires `absl` as dependency but doesn't resolve it when `VELOX_BUILD_TESTING=OFF`. The patch fixes the issue. Fixes build error: ``` CMake Error at build/_deps/s2geometry-src/CMakeLists.txt:54 (find_package): By not providing "Findabsl.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "absl", but CMake did not find one. Could not find a package configuration file provided by "absl" with any of the following names: abslConfig.cmake absl-config.cmake Add the installation prefix of "absl" to CMAKE_PREFIX_PATH or set "absl_DIR" to a directory containing one of the above files. If "absl" provides a separate development package or SDK, be sure it has been installed. ``` Pull Request resolved: facebookincubator#17225 Reviewed By: kgpai Differential Revision: D101581081 Pulled By: peterenescu fbshipit-source-id: d5348c99aad81023542a0fb31ea1995466d10e6d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After PR #15511, Velox + GEO now requires
abslas dependency but doesn't resolve it whenVELOX_BUILD_TESTING=OFF. The patch fixes the issue.Fixes build error: