Skip to content

starlark: Export the RecordTypeMatcher for users in the public API #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PhilipMetzger wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

starlark: Export the RecordTypeMatcher for users in the public API #1283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions starlark-rust/starlark/src/values/types/record.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,5 @@ pub(crate) mod record_type;
pub(crate) mod ty_record_type;

pub use crate::values::record::instance::Record;
pub use crate::values::record::matcher::RecordTypeMatcher;
pub use crate::values::record::record_type::RecordType;
4 changes: 3 additions & 1 deletion starlark-rust/starlark/src/values/types/record/matcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,11 @@ use crate::values::types::type_instance_id::TypeInstanceId;
use crate::values::typing::type_compiled::matcher::TypeMatcher;
use crate::values::typing::type_compiled::matcher::TypeMatcherDyn;

/// Allows you to compare `Record`'s from different files, since they otherwise have no unique
/// identity.
#[derive(Hash, Debug, Eq, PartialEq, Clone, Dupe, Allocative, Pagable)]
#[pagable_typetag(TypeMatcherDyn)]
pub(crate) struct RecordTypeMatcher {
pub struct RecordTypeMatcher {
pub(crate) id: TypeInstanceId,
}

Expand Down