Skip to content

starlark: Export the RecordTypeMatcher for users in the public API#1283

Open
PhilipMetzger wants to merge 1 commit into
facebook:mainfrom
PhilipMetzger:pm/qyqzsvqvznxv
Open

starlark: Export the RecordTypeMatcher for users in the public API#1283
PhilipMetzger wants to merge 1 commit into
facebook:mainfrom
PhilipMetzger:pm/qyqzsvqvznxv

Conversation

@PhilipMetzger
Copy link
Copy Markdown

This fixes facebook/starlark-rust#120. Since it allows users now to compare records from different files.

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Apr 3, 2026

Hi @PhilipMetzger!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 3, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 3, 2026

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D99510872. (Because this pull request was imported automatically, there will not be any future comments.)

@PhilipMetzger
Copy link
Copy Markdown
Author

cc @ndmitchell for some visibility. I also am writing a patch for facebook/starlark-rust#144 so it'd be nice if these could also be included in the new starlark-rs release.

Copy link
Copy Markdown
Contributor

@ndmitchell ndmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@ndmitchell
Copy link
Copy Markdown
Contributor

This has CI failures because other pieces are still private.

@PhilipMetzger
Copy link
Copy Markdown
Author

This has CI failures because other pieces are still private.

Should be fixed now.

This fixes facebook/starlark-rust#120. Since
it allows users now to compare records from different files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

disambiguating record types defined in different files

2 participants