starlark: Export the RecordTypeMatcher for users in the public API#1283
starlark: Export the RecordTypeMatcher for users in the public API#1283PhilipMetzger wants to merge 1 commit into
RecordTypeMatcher for users in the public API#1283Conversation
|
Hi @PhilipMetzger! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
989be90 to
034629b
Compare
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D99510872. (Because this pull request was imported automatically, there will not be any future comments.) |
|
cc @ndmitchell for some visibility. I also am writing a patch for facebook/starlark-rust#144 so it'd be nice if these could also be included in the new starlark-rs release. |
034629b to
6859f64
Compare
ndmitchell
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
This has CI failures because other pieces are still private. |
6859f64 to
91208e2
Compare
Should be fixed now. |
This fixes facebook/starlark-rust#120. Since it allows users now to compare records from different files.
91208e2 to
21272f5
Compare
This fixes facebook/starlark-rust#120. Since it allows users now to compare records from different files.