Skip to content

flare: name the PollingFoundation owner Flare Foundation - #2985

Open
fassko wants to merge 2 commits into
ethereum:masterfrom
fassko:flare-governance
Open

flare: name the PollingFoundation owner Flare Foundation#2985
fassko wants to merge 2 commits into
ethereum:masterfrom
fassko:flare-governance

Conversation

@fassko

@fassko fassko commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Rename the owner on the two unattested PollingFoundation descriptors (Flare's governance/FIP-voting contract) from "Flare Labs" to "Flare Foundation"
  • Add coverage tests for both propose() overloads (executable and signaling-only), which the registry's selector-coverage check now requires

Split out of #2984 — PollingFoundation is a governance contract, unrelated to the FXRP work there.

Test plan

  • Verified locally: 4/4 test cases pass for each descriptor
  • check-selector-coverage.js passes for both descriptors
  • CI descriptor validation

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Clear Signing Tests

Tested e00780b · started 2026-09-28 07:54 UTC · finished 2026-09-28 07:55 UTC

📊 Open the test report

Entity Descriptor Case @ethereum-sourcify/clear-signing@0.2.2 llbartekll/clear-signing@0.1.0
flare calldata-GovernanceVotePower-Flare Delegate governance vote power - chain 14 ✅ ✅
flare calldata-GovernanceVotePower-Flare Undelegate governance vote power - chain 14 ✅ ✅
flare calldata-GovernanceVotePower-Songbird Delegate governance vote power - chain 19 ✅ ✅
flare calldata-GovernanceVotePower-Songbird Undelegate governance vote power - chain 19 ✅ ✅
flare calldata-PollingFoundation-Flare Cast vote For - chain 14 ✅ ✅
flare calldata-PollingFoundation-Flare Cast vote Against - chain 14 ✅ ✅
flare calldata-PollingFoundation-Flare Create proposal with execution - chain 14 ✅ ✅
flare calldata-PollingFoundation-Flare Create proposal without execution - chain 14 ✅ ✅
flare calldata-PollingFoundation-Songbird Cast vote For - chain 19 ✅ ✅
flare calldata-PollingFoundation-Songbird Cast vote Against - chain 19 ✅ ✅
flare calldata-PollingFoundation-Songbird Create proposal with execution - chain 19 ✅ ✅
flare calldata-PollingFoundation-Songbird Create proposal without execution - chain 19 ✅ ✅
flare calldata-PollingManagementGroup-Flare Cast vote For - chain 14 ✅ ✅
flare calldata-PollingManagementGroup-Flare Cast vote Against - chain 14 ✅ ✅
flare calldata-PollingManagementGroup-Flare Create proposal without settings - chain 14 ✅ ✅
flare calldata-PollingManagementGroup-Flare Create proposal with settings - chain 14 ✅ ✅
flare calldata-PollingManagementGroup-Songbird Cast vote For - chain 19 ✅ ✅
flare calldata-PollingManagementGroup-Songbird Cast vote Against - chain 19 ✅ ✅
flare calldata-PollingManagementGroup-Songbird Create proposal without settings - chain 19 ✅ ✅
flare calldata-PollingManagementGroup-Songbird Create proposal with settings - chain 19 ✅ ✅

✅ pass · ❌ fail · ⚠️ error · ⏭️ skipped · — not run

📋 View test details

@github-actions github-actions Bot added the descriptors Changes to clear signing descriptors label Sep 14, 2026
@fassko fassko mentioned this pull request Sep 14, 2026
Open
2 of 3 tasks
@github-actions

github-actions Bot commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Clear signing recommendations

These are suggestions. They do not block this pull request.

16 format(s) have no interpolatedIntent. A wallet prefers it over intent, because it puts the values of the transaction in the sentence that the signer reads.

  • registry/flare/calldata-GovernanceVotePower-Flare.json — delegate(address _to)
  • registry/flare/calldata-GovernanceVotePower-Flare.json — undelegate()
  • registry/flare/calldata-GovernanceVotePower-Songbird.json — delegate(address _to)
  • registry/flare/calldata-GovernanceVotePower-Songbird.json — undelegate()
  • registry/flare/calldata-PollingManagementGroup-Flare.json — castVote(uint256 _proposalId, uint8 _support)
  • registry/flare/calldata-PollingManagementGroup-Flare.json — propose(string _description)
  • registry/flare/calldata-PollingManagementGroup-Flare.json — proposeWithSettings(string _description, (bool accept, uint256 votingStartTs, uint256 votingPeriodSeconds, uint256 thresholdConditionBIPS, uint256 majorityConditionBIPS) _settings)
  • registry/flare/calldata-PollingManagementGroup-Songbird.json — castVote(uint256 _proposalId, uint8 _support)
  • registry/flare/calldata-PollingManagementGroup-Songbird.json — propose(string _description)
  • registry/flare/calldata-PollingManagementGroup-Songbird.json — proposeWithSettings(string _description, (bool accept, uint256 votingStartTs, uint256 votingPeriodSeconds, uint256 thresholdConditionBIPS, uint256 majorityConditionBIPS) _settings)
  • registry/flare/calldata-PollingFoundation-Flare.json — castVote(uint256 _proposalId, uint8 _support)
  • registry/flare/calldata-PollingFoundation-Flare.json — propose(address[] _targets, uint256[] _values, bytes[] _calldatas, string _description, (bool accept, uint256 votingStartTs, uint256 votingPeriodSeconds, uint256 vpBlockPeriodSeconds, uint256 threshol
  • registry/flare/calldata-PollingFoundation-Flare.json — propose(string _description, (bool accept, uint256 votingStartTs, uint256 votingPeriodSeconds, uint256 vpBlockPeriodSeconds, uint256 thresholdConditionBIPS, uint256 majorityConditionBIPS) _settings)
  • registry/flare/calldata-PollingFoundation-Songbird.json — castVote(uint256 _proposalId, uint8 _support)
  • registry/flare/calldata-PollingFoundation-Songbird.json — propose(address[] _targets, uint256[] _values, bytes[] _calldatas, string _description, (bool accept, uint256 votingStartTs, uint256 votingPeriodSeconds, uint256 vpBlockPeriodSeconds, uint256 threshol
  • registry/flare/calldata-PollingFoundation-Songbird.json — propose(string _description, (bool accept, uint256 votingStartTs, uint256 votingPeriodSeconds, uint256 vpBlockPeriodSeconds, uint256 thresholdConditionBIPS, uint256 majorityConditionBIPS) _settings)

fassko and others added 2 commits September 28, 2026 10:54
@fassko @claude
flare: name the owner Flare Foundation on PollingFoundation, add prop…
6221f4f 
…ose() tests

The two PollingFoundation descriptors carry no auditor attestation, so
the owner string can be corrected in place. Adds coverage tests for
both propose() overloads (executable and signaling-only), which the
registry's selector-coverage check now requires.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@fassko @claude
feat: add PollingManagementGroup and GovernanceVotePower calldata des…
e00780b 
…criptors

Add ERC-7730 clear-signing descriptors and testsv2 fixtures for
PollingManagementGroup (castVote/propose/proposeWithSettings) and
GovernanceVotePower (delegate/undelegate) on Flare and Songbird,
following the PollingFoundation conventions. Function signatures were
sourced from the verified on-chain ABIs via `erc7730 generate`.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

descriptors Changes to clear signing descriptors

Projects

Clear Signing PM
Status: Triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fassko @kuzdogan