Conversation
Closed
2 tasks
Contributor
Clear Signing TestsTested
✅ pass · ❌ fail · |
Contributor
Clear signing recommendationsThese are suggestions. They do not block this pull request. 22 format(s) have no
|
fassko
changed the title
2 of 3 tasks
fassko
force-pushed
the
flare-fxrp
branch
2 times, most recently
from
September 28, 2026 07:23
0bbf0ed to
0dcb0c3
Compare
…TagManager Introduces calldata descriptors for AssetManager, FAsset, and MintingTagManager for both Flare and Songbird, with test cases for each. PollingFoundation (unrelated governance contract) moved to its own PR. Also adds the coverage tests the registry's new selector-coverage check requires for two already-attested descriptors this PR does not otherwise touch, DistributionToDelegators-Flare and ValidatorRewardManager-Flare, keeping their expectations at "Flare Labs" since that's what their attestation covers. Executor Fee / Reservation Fee fields expect FLR/SGB rather than the ETH the Rust test runner prints today for chains 14/19; llbartekll/clear-signing#15 adds the missing native-currency entries that make it so. Not included: RewardManager-{Flare,Songbird}. Both are attested and render blank in the Sourcify runner (nested field groups are unsupported), and the index disallows a second descriptor at the same address, so there's no way to land a fix here — needs a maintainer decision on how to replace an attested-but-unrenderable descriptor. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
17 of 28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out of #2982. See #2983 for WNat, #2985 for the PollingFoundation owner rename (unrelated governance contract, moved out of this PR).
Not included: RewardManager-{Flare,Songbird}. Both are attested and render blank (
UNSUPPORTED_NESTED_FIELD_GROUP) in the Sourcify test runner, and the registry's index allows only one descriptor per (chainId, address) — so there's no versioned-file path to a fix while the contract address stays the same. This needs a maintainer call on how to replace an attested-but-unrenderable descriptor; happy to prepare it once there's a direction.Amount fields (Reservation Fee) expect FLR/SGB, which the Sourcify runner already gets right for these chains; the Rust runner needs llbartekll/clear-signing#15 (native-currency table for Flare/Songbird) merged and its pin bumped in
.github/actions/run-rust-tests/action.ymlbefore that job goes green here.Test plan
check-selector-coverage.jspasses for every changed descriptor🤖 Generated with Claude Code