Skip to content

fix(pglite-socket): propagate server startup errors from start() #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yanhu007 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

fix(pglite-socket): propagate server startup errors from start() #972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/pglite-socket/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,16 +607,19 @@ export class PGLiteSocketServer extends EventTarget {
return new Promise<void>((resolve, reject) => {
if (!this.server) return reject(new Error('Server not initialized'))

let listening = false

this.server.on('error', (err) => {
this.log(`start: server error:`, err)
this.dispatchEvent(new CustomEvent('error', { detail: err }))
if (!this.active) {
if (!listening) {
reject(err)
}
})

if (this.path) {
this.server.listen(this.path, () => {
listening = true
this.log(`start: server listening on ${this.getServerConn()}`)
this.dispatchEvent(
new CustomEvent('listening', {
Expand All @@ -628,6 +631,7 @@ export class PGLiteSocketServer extends EventTarget {
} else {
const server = this.server
server.listen(this.port, this.host, () => {
listening = true
const address = server.address()
// We are not using pipes, so return type should be AddressInfo
if (address === null || typeof address !== 'object') {
Expand Down