fix(pglite-socket): propagate server startup errors from start()#972
Open
Yanhu007 wants to merge 1 commit intoelectric-sql:mainfrom
Open
fix(pglite-socket): propagate server startup errors from start()#972Yanhu007 wants to merge 1 commit intoelectric-sql:mainfrom
Yanhu007 wants to merge 1 commit intoelectric-sql:mainfrom
Conversation
The error handler in start() checks `if (!this.active)` before calling reject(), but this.active is set to true before the server.listen() call. When listen fails (e.g. EACCES, EADDRINUSE), the error is logged and emitted but reject() is never called, causing the start() Promise to hang forever. Replace the this.active check with a local `listening` flag that is only set to true inside the listen callback. This ensures startup errors always reject the Promise. Fixes electric-sql#964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #964
PGLiteSocketServer.start()hangs forever when the underlying server fails to start (e.g.EACCES,EADDRINUSE). The error is logged and emitted viaCustomEvent, but the Promise never rejects.Root Cause
The error handler checks
if (!this.active)before callingreject(), butthis.activeis set totrueat line 601 — beforeserver.listen()is called. Whenlistenemits an error,!this.activeisfalse, soreject()is never reached.Fix
Replace the
this.activecheck with a locallisteningflag that is only set totrueinside thelistencallback: