Fix requalifying type variable uses during viewpoint adaptation#799
Open
aosen-xiong wants to merge 28 commits into
Open
Fix requalifying type variable uses during viewpoint adaptation#799aosen-xiong wants to merge 28 commits into
aosen-xiong wants to merge 28 commits into
Conversation
wmdietl
requested changes
Jun 28, 2024
wmdietl
changed the title
aosen-xiong
commented
Jul 4, 2024
Collaborator
Author
|
Maybe this PR could be better after we formalized |
Member
Adding |
Member
|
Is this PR ready for review? |
3 tasks
aosen-xiong
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked change from #614.
This PR fixes viewpoint adaptation when requalifying type variable uses.
It preserves the real use-site annotation on type variables like
@AE while adapting their bounds, so annotated uses correctly override the actual type argument and unannotated uses like E still keep the actual type argument annotation. It also avoids dropping annotations from unrelated qualifier hierarchies.