fix viewpoint adaptation#614
Closed
AndrewShf wants to merge 7 commits into
Closed
Conversation
Member
|
Closed in favor of #799. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the manual (https://eisop.github.io/cf/manual/manual.html#type-variable-use), if the type variable use and the corresponding type argument both are annotated by type qualifiers, we will keep the one presented on the type variable use.
For example,
The
myFieldfield of the local variableMyClass<@NonNull Object> mcstill has type@Nullable.However, this rule is broken in context-sensitive type systems (For example, PICO, viewpointtest)
Consider the viewpointtest checker
viewpointtest is a context-sensitive type system for testing purposes.
@A, @Bare not incompatible type qualifiers. It acts differently than what we have discussed earlier when doing type substitution ford.element, replacing@A Ewith@B Element, instead of keeping@Aon the field, and would report anassignment.type.incompatibleerror in the assignment of thestatic testmethod.We realize it is in the process of viewpoint adaptation, the type substitution goes wrong, and we fix the bug there.