Skip to content

Feature #3395 remove r at unittest #3400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsoh-u wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Feature #3395 remove r at unittest #3400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
feabbab
#3395 Removed MET_TEST_RSCRIPT
Jun 9, 2026
bb76be7
#3395 Repalcing mgnc.R and mpnc.R
Jun 9, 2026
a056651
#3395 Removed unused script and unit tests
Jun 9, 2026
444b7cb
#3395 Removed unit_trmm2nc.xml and unit_plot_tc.xml
Jun 9, 2026
23478d5
#3395 Changed a R script to a python script
Jun 9, 2026
5cc50ed
#3395 Removed push origin plot_tc and trmm2nc
Jun 10, 2026
834f793
#3395 Used [[ notation (SonarQube)
Jun 16, 2026
21dccf7
#3395 Updated EOL (Unix format)
Jun 16, 2026
66fc16e
#3395 Corrected typo
Jun 16, 2026
e8678f9
#3395 Added one more arg to check_size_and_return
Jun 16, 2026
3f2d307
#3395 Removed shell scripts with MET_TEST_RSCRIPT
Jun 16, 2026
a3cab96
#3395 Changed MET_PYTHON_BIN_EXE to MET_TEST_MET_PYTHON_EXE
Jun 25, 2026
0024601
#3395 Added verbose_msg to reduce Cognitive Complexity
Jun 25, 2026
0c8c8b9
#3395 Added line_break optionj to verbose_msg
Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/jobs/test_env_vars.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ export MET_TEST_DIFF=/data/output/met_test_diff

export METPLUS_DIR=/metplus

export MET_TEST_RSCRIPT=/usr/bin/Rscript
export MET_TEST_MET_PYTHON_EXE=/usr/local/bin/python3

# Set OMP_NUM_THREADS as the number of processors available
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,9 @@ jobs:
matrix:
include:
- jobid: 'job1'
tests: 'ascii2nc_indy pb2nc_indy tc_dland tc_pairs tc_stat plot_tc tc_rmw rmw_analysis tc_diag tc_gen'
tests: 'ascii2nc_indy pb2nc_indy tc_dland tc_pairs tc_stat tc_rmw rmw_analysis tc_diag tc_gen'
- jobid: 'job2'
tests: 'met_test_scripts mode_multivar mtd airnow gsi_tools netcdf modis series_analysis wwmca_regrid gen_vx_mask interp_shape grid_diag grib_tables lidar2nc shift_data_plane trmm2nc aeronet wwmca_plot ioda2nc gaussian'
tests: 'met_test_scripts mode_multivar mtd airnow gsi_tools netcdf modis series_analysis wwmca_regrid gen_vx_mask interp_shape grid_diag grib_tables lidar2nc shift_data_plane aeronet wwmca_plot ioda2nc gaussian'
fail-fast: false
steps:
- uses: actions/checkout@v6
Expand Down
1 change: 0 additions & 1 deletion docs/Contributors_Guide/testing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ Example::
Other environment variables required for some of the unit tests include:

* **MET_TEST_MET_PYTHON_EXE** - Path to Python executable to use for Python Embedding tests
* **MET_TEST_RSCRIPT** - Path to Rscript executable used to run R script tests

Run the tests
^^^^^^^^^^^^^
Expand Down
3 changes: 0 additions & 3 deletions internal/scripts/environment/development.docker
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ export LDFLAGS="${LDFLAGS} -Wl,-rpath,/usr/local/lib:/usr/lib64"
# Variables required to run MET
export MET_TEST_INPUT=${MET_PROJ_DIR}/MET_test_data/unit_test

# Define Rscript to use a version with the ncdf4 package 1.17 or later
export MET_TEST_RSCRIPT=/usr/bin/Rscript

# Set make arguments to build using multiple jobs
export MAKE_ARGS="-j 5"

Expand Down
3 changes: 0 additions & 3 deletions internal/scripts/environment/development.seneca
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,6 @@ export MET_TEST_INPUT=${MET_PROJ_DIR}/MET_test_data/unit_test
# Path to METplus, used for diff tests
export METPLUS_DIR=${MET_PROJ_DIR}/MET_regression/METplus-develop

# Define Rscript to use a version with the ncdf4 package 1.17 or later
export MET_TEST_RSCRIPT=/nrit/ral/R-4.4.0/bin/Rscript

# Define runtime Python version
export MET_TEST_MET_PYTHON_EXE=${MET_PYTHON_BIN_EXE}

Expand Down
3 changes: 0 additions & 3 deletions internal/scripts/environment/development.seneca_intel_oneapi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,6 @@ export LDFLAGS="${LDFLAGS} -L${ADDTL_DIR} -L${ADDTL_DIR2} -L${ADDTL_DIR3} -L${AD
# Variables required to run MET
export MET_TEST_INPUT=${MET_PROJ_DIR}/MET_test_data/unit_test

# Define Rscript to use a version with the ncdf4 package 1.17 or later
export MET_TEST_RSCRIPT=/nrit/ral/R-4.4.0/bin/Rscript

# Define runtime Python version
export MET_TEST_MET_PYTHON_EXE=${MET_PYTHON_BIN_EXE}

Expand Down
45 changes: 0 additions & 45 deletions internal/test_unit/R_test/comp_diff.R
View file
Open in desktop

This file was deleted.

139 changes: 0 additions & 139 deletions internal/test_unit/R_test/comp_dir.R
View file
Open in desktop

This file was deleted.

56 changes: 0 additions & 56 deletions internal/test_unit/R_test/comp_nc.R
View file
Open in desktop

This file was deleted.

51 changes: 0 additions & 51 deletions internal/test_unit/R_test/comp_stat.R
View file
Open in desktop

This file was deleted.

Loading