Feature #3395 remove r at unittest#3400
Conversation
|
As discussed at the METplus project meeting on June 16, 2026, recommend removing all references to the |
|
There was a problem hiding this comment.
@hsoh-u can you please take a look at the env vars used to access python in the test_unit/bin/ scripts? We're using both $MET_TEST_MET_PYTHON_BIN_EXE and $MET_PYTHON_BIN_EXE.
Seems like we should be handling it consistently.
| MET_TEST_RSCRIPT=${MET_TEST_RSCRIPT:-/usr/local/bin/Rscript} | ||
| MGNC=$MET_TEST_BASE/R_test/mgnc.R | ||
| export MET_TEST_BASE=${MET_TEST_BASE} | ||
| [[ -z $MET_PYTHON_BIN_EXE ]] && MET_PYTHON_BIN_EXE=python3 |
There was a problem hiding this comment.
I think we should probably switch from $MET_PYTHON_BIN_EXE to $MET_TEST_MET_PYTHON_EXE which appears in unit_test.sh. Just seems like all the test_unit/bin scripts should access python in the same way.
| MET_TEST_RSCRIPT=${MET_TEST_RSCRIPT:-/usr/local/bin/Rscript} | ||
| MPNC=$MET_TEST_BASE/R_test/mpnc.R | ||
| export MET_TEST_BASE=${MET_TEST_BASE} | ||
| [[ -z $MET_PYTHON_BIN_EXE ]] && MET_PYTHON_BIN_EXE=python3 |
There was a problem hiding this comment.
I think we should probably switch from $MET_PYTHON_BIN_EXE to $MET_TEST_MET_PYTHON_EXE which appears in unit_test.sh. Just seems like all the test_unit/bin scripts should access python in the same way.



Expected Differences
Two unit tests (
unit_trmm2nc.xmlandunit_plot_tc.xml) were removed atinternal/test_unit/bin/unit_test.shand GHA. This causes 7 less outputs:Removed PERL and R scripts at:
Two R scripts were converted to python
Removed the shell scripts with reference of MET_TEST_RSCRIPT, but associated R scripts were not converted to Python.
Two shell scripts were modified. MET_TEST_RSCRIPT was replaced with MET_PYTHON_BIN_EXE.
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
ran unit test manually and by using GHA
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
NA
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
Do these changes include sufficient testing updates? [No]
Will this PR result in changes to the MET test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
7 less output files at
trmm2ncandplot_tcsub directoriesIf yes, create a new Update Truth METplus issue to describe them.
Not sure
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release