Skip to content

Feature #3395 remove r at unittest#3400

Open
hsoh-u wants to merge 11 commits into
developfrom
feature_3395_remove_R_at_unittest
Open

Feature #3395 remove r at unittest#3400
hsoh-u wants to merge 11 commits into
developfrom
feature_3395_remove_R_at_unittest

Conversation

@hsoh-u

@hsoh-u hsoh-u commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Expected Differences

Two unit tests (unit_trmm2nc.xml and unit_plot_tc.xml) were removed at internal/test_unit/bin/unit_test.sh and GHA. This causes 7 less outputs:

  • trmm2nc/trmm_2008080812_12hr_grid.nc
  • trmm2nc/trmm_2012040912_3hr_grid.nc
  • plot_tc/TK_ERR_boxplot.log
  • plot_tc/plot_tc_TCMPR_data.tcst
  • plot_tc/ABS_AMAX_WIND-BMAX_WIND_boxplot.png
  • plot_tc/ABS_AMAX_WIND-BMAX_WIND_boxplot.log
  • plot_tc/TK_ERR_boxplot.png

Removed PERL and R scripts at:

  • internal/test_unit/lib
  • internal/test_unit/perl
  • internal/test_unit/R_test

Two R scripts were converted to python

  • internal/test_unit/python/mgnc.py (from internal/test_unit/R_test/mgnc.R)
  • internal/test_unit/python/mpnc.py (from internal/test_unit/R_test/mpnc.R)

Removed the shell scripts with reference of MET_TEST_RSCRIPT, but associated R scripts were not converted to Python.

  • internal/test_unit/bin/comp_nc_features.sh
  • internal/test_unit/bin/comp_nc.sh
  • internal/test_unit/bin/comp_stat.sh
  • internal/test_unit/bin/comp_diff.sh

Two shell scripts were modified. MET_TEST_RSCRIPT was replaced with MET_PYTHON_BIN_EXE.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    ran unit test manually and by using GHA

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

NA

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the MET test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

7 less output files at trmm2nc and plot_tc sub directories

  • Will this PR result in changes to existing METplus Use Cases? [No]

    If yes, create a new Update Truth METplus issue to describe them.

Not sure

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u requested a review from JohnHalleyGotway June 15, 2026 17:47
@hsoh-u hsoh-u linked an issue Jun 15, 2026 that may be closed by this pull request
21 tasks
@github-project-automation github-project-automation Bot moved this to 🩺 Needs Triage in METplus-13.0 Development Jun 16, 2026
@hsoh-u hsoh-u moved this from 🩺 Needs Triage to 🔎 In review in METplus-13.0 Development Jun 16, 2026
@JohnHalleyGotway JohnHalleyGotway requested review from georgemccabe and removed request for JohnHalleyGotway June 16, 2026 16:24
@JohnHalleyGotway

JohnHalleyGotway commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

As discussed at the METplus project meeting on June 16, 2026, recommend removing all references to the $MET_TEST_RSCRIPT environment variable throughout.

@sonarqubecloud

Copy link
Copy Markdown

@JohnHalleyGotway JohnHalleyGotway changed the title Feature 3395 remove r at unittest Feature #3395 remove r at unittest Jun 18, 2026

@JohnHalleyGotway JohnHalleyGotway left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsoh-u can you please take a look at the env vars used to access python in the test_unit/bin/ scripts? We're using both $MET_TEST_MET_PYTHON_BIN_EXE and $MET_PYTHON_BIN_EXE.

Seems like we should be handling it consistently.

MET_TEST_RSCRIPT=${MET_TEST_RSCRIPT:-/usr/local/bin/Rscript}
MGNC=$MET_TEST_BASE/R_test/mgnc.R
export MET_TEST_BASE=${MET_TEST_BASE}
[[ -z $MET_PYTHON_BIN_EXE ]] && MET_PYTHON_BIN_EXE=python3

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably switch from $MET_PYTHON_BIN_EXE to $MET_TEST_MET_PYTHON_EXE which appears in unit_test.sh. Just seems like all the test_unit/bin scripts should access python in the same way.

MET_TEST_RSCRIPT=${MET_TEST_RSCRIPT:-/usr/local/bin/Rscript}
MPNC=$MET_TEST_BASE/R_test/mpnc.R
export MET_TEST_BASE=${MET_TEST_BASE}
[[ -z $MET_PYTHON_BIN_EXE ]] && MET_PYTHON_BIN_EXE=python3

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably switch from $MET_PYTHON_BIN_EXE to $MET_TEST_MET_PYTHON_EXE which appears in unit_test.sh. Just seems like all the test_unit/bin scripts should access python in the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In review

Development

Successfully merging this pull request may close these issues.

Remove R dependency from the MET unit test logic

2 participants