Skip to content

Reenable Microsoft.CodeAnalysis.PublicApiAnalyzers #13486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rainersigwald wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Reenable Microsoft.CodeAnalysis.PublicApiAnalyzers #13486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
50afea8
Final branding for 18.6 release (#13473)
MichalPavlik Apr 2, 2026
443fc07
Reenable Microsoft.CodeAnalysis.PublicApiAnalyzers
rainersigwald Apr 2, 2026
07e1ba3
Suppress existing RS002* API-design violations
rainersigwald Apr 3, 2026
e0277fa
Add 18.6 PublicAPI shipped baselines
rainersigwald Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,9 @@
you don't get those defaults.
SYSLIB0011: Removing binary formatter will happen as part of a larger .NET-wide effort.
SYSLIB0037 & SYSLIB0044: The deprecated AssemblyName members could require a bigger refactor for us: https://github.com/dotnet/msbuild/issues/7902
RS0016 & RS0017: Roslyn analyzers seem to be bugged, claiming that API's that exist don't and vise-versa: https://github.com/dotnet/msbuild/issues/7903
-->
-->

<NoWarn>$(NoWarn);NU1507;NU1603;NU5105;1701;1702;SYSLIB0011;SYSLIB0037;SYSLIB0044;RS0016;RS0017;</NoWarn>
<NoWarn>$(NoWarn);NU1507;NU1603;NU5105;1701;1702;SYSLIB0011;SYSLIB0037;SYSLIB0044;</NoWarn>
<!-- Loading certificate data through the constructor or Import is obsolete. Use X509CertificateLoader instead to load certific
ates https://learn.microsoft.com/en-gb/dotnet/fundamentals/syslib-diagnostics/syslib0057 -->
<NoWarn>$(NoWarn);SYSLIB0057;</NoWarn>
Expand Down
6 changes: 3 additions & 3 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<Project>
<Project>

<Import Project="Version.Details.props" />

<PropertyGroup>
<VersionPrefix>18.6.0</VersionPrefix>
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
<VersionPrefix>18.6.0</VersionPrefix><DotNetFinalVersionKind>release</DotNetFinalVersionKind><!-- Keep next to VersionPrefix to create a conflict in forward-flow -->
Copy link
Copy Markdown
Member

@JanProvaznik JanProvaznik Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase?

<PreReleaseVersionLabel>servicing</PreReleaseVersionLabel>
<PackageValidationBaselineVersion>18.5.0-preview-26126-01</PackageValidationBaselineVersion>
<AssemblyVersion>15.1.0.0</AssemblyVersion>

Expand Down
3 changes: 3 additions & 0 deletions eng/dependabot/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
<PackageVersion Include="LargeAddressAware" Version="1.0.5" />
<PackageVersion Update="LargeAddressAware" Condition="'$(LargeAddressAwareVersion)' != ''" Version="$(LargeAddressAwareVersion)" />

<PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="5.0.0-1.25277.114" />
<PackageVersion Update="Microsoft.CodeAnalysis.PublicApiAnalyzers" Condition="'$(MicrosoftCodeAnalysisPublicApiAnalyzersVersion)' != ''" Version="$(MicrosoftCodeAnalysisPublicApiAnalyzersVersion)" />

<PackageVersion Include="Microsoft.CodeCoverage" Version="18.0.1" />
<PackageVersion Update="Microsoft.CodeCoverage" Condition="'$(MicrosoftCodeCoverageVersion)' != ''" Version="$(MicrosoftCodeCoverageVersion)" />

Expand Down
2 changes: 2 additions & 0 deletions src/Build/BackEnd/Components/ProjectCache/CacheContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ public class CacheContext
public MSBuildFileSystemBase FileSystem { get; }
public IReadOnlyCollection<string> RequestedTargets { get; }

[System.Diagnostics.CodeAnalysis.SuppressMessage("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Already shipped")]
public CacheContext(
IReadOnlyDictionary<string, string> pluginSettings,
MSBuildFileSystemBase fileSystem,
Expand All @@ -33,6 +34,7 @@ public CacheContext(
{
}

[System.Diagnostics.CodeAnalysis.SuppressMessage("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Already shipped")]
public CacheContext(
IReadOnlyDictionary<string, string> pluginSettings,
MSBuildFileSystemBase fileSystem,
Expand Down
1 change: 1 addition & 0 deletions src/Build/BackEnd/Components/ProjectCache/Experimental/CacheContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ public CacheContext(
{
}

[System.Diagnostics.CodeAnalysis.SuppressMessage("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Already shipped")]
public CacheContext(
IReadOnlyDictionary<string, string> pluginSettings,
MSBuildFileSystemBase fileSystem,
Expand Down
1 change: 1 addition & 0 deletions src/Build/BackEnd/Components/ProjectCache/ProjectCacheDescriptor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ public static ProjectCacheDescriptor FromInstance(ProjectCachePluginBase pluginI
=> new ProjectCacheDescriptor(pluginAssemblyPath: null, pluginSettings, pluginInstance);

[Obsolete("Microsoft.Build.Experimental.ProjectCachePluginBase was moved to Microsoft.Build.ProjectCache, migrate your plugins and use the new type instead.")]
[System.Diagnostics.CodeAnalysis.SuppressMessage("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Already shipped")]
public static ProjectCacheDescriptor FromInstance(
#pragma warning disable CS0618 // Type or member is obsolete
Experimental.ProjectCache.ProjectCachePluginBase experimentalPluginInstance,
Expand Down
1 change: 1 addition & 0 deletions src/Build/BackEnd/Components/SdkResolution/SdkResolverServiceException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ namespace Microsoft.Build.BackEnd.SdkResolution
/// </summary>
public class SdkResolverServiceException : BuildExceptionBase
{
[System.Diagnostics.CodeAnalysis.SuppressMessage("ApiDesign", "RS0022:Constructor make noninheritable base class inheritable", Justification = "Shipped in 18.0")]
public SdkResolverServiceException(string message, params string[] args)
: base(string.Format(message, args))
{
Expand Down
Loading