Reenable Microsoft.CodeAnalysis.PublicApiAnalyzers#13486
Draft
rainersigwald wants to merge 4 commits intodotnet:mainfrom
Draft
Reenable Microsoft.CodeAnalysis.PublicApiAnalyzers#13486rainersigwald wants to merge 4 commits intodotnet:mainfrom
rainersigwald wants to merge 4 commits intodotnet:mainfrom
Conversation
## Release 18.6 — Phase 4: Final Branding Tracking issue: dotnet#13468 ### Changes - Add \<DotNetFinalVersionKind>release</DotNetFinalVersionKind>\ on the \VersionPrefix\ line (creates merge conflict for forward-flow) - Change \PreReleaseVersionLabel\ from \preview\ to \servicing\ Generated by \scripts/Stabilize-Release.ps1\. ### Next steps after merge - Bootstrap OptProf for \�s18.6\ - Babysit VS insertion PR into VS \main\ before insiders snap (Apr 3) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
I'm adjusting the TF-specific stuff to have more conventional names: netfx for .NET Framework and, net for .NET 10/core.
Since we didn't catch these when we introduced them, baseline them, but it looks like at least one VMR break could have been prevented with the rules so let's keep them enabled.
Populate the restored PublicAPI baseline files for the shipping MSBuild assemblies from the 18.6 release surface and add matching empty unshipped files so PublicApiAnalyzer validates the branch cleanly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rainersigwald
force-pushed
the
roslyn-publicapi-baseline-18.6
branch
from
c0df50c to
e0277fa
Compare
JanProvaznik
reviewed
Apr 7, 2026
| <PropertyGroup> | ||
| <VersionPrefix>18.6.0</VersionPrefix> | ||
| <PreReleaseVersionLabel>preview</PreReleaseVersionLabel> | ||
| <VersionPrefix>18.6.0</VersionPrefix><DotNetFinalVersionKind>release</DotNetFinalVersionKind><!-- Keep next to VersionPrefix to create a conflict in forward-flow --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some problems with this analyzer and switched to the package-based compat analyzer in #8116. However, since then I've wished we had a more explicit indicator of adding public API, which PublicApiAnalyzers provides (in the form of requiring a diff to the
PublicAPI.Unshipped.txtfiles).There are some new rules in the newer versions of this analyzer that catch compat problems we introduced (and, unfortunately, shipped), so I have grandfathered those in with attribute-level suppressions.