Skip to content

Name a checkbox without a label by its accessible name #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rezabakhshilaktasaraei wants to merge 1 commit into from
Closed

Name a checkbox without a label by its accessible name #362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ui/widgets/checkbox.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,11 @@ class Checkbox : public RippleButton, public ClickHandlerHost {
return QAccessible::Role::CheckBox;
}
QString accessibilityName() override {
return _text.toString();
// A checkbox with no label of its own - beside a poll answer, in a
// list row - is named by what stands for it, through the widget's
// accessible name.
const auto text = _text.toString();
return text.isEmpty() ? RpWidget::accessibilityName() : text;
Comment on lines +212 to +216

@ilya-fedin ilya-fedin Sep 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong, accessible name always takes the priority over this method

}
AccessibilityState accessibilityState() const override;
void accessibilityDoAction(const QString &name) override;
Expand Down