Name a checkbox without a label by its accessible name - #362
Closed
rezabakhshilaktasaraei wants to merge 1 commit into
Closed
Name a checkbox without a label by its accessible name#362rezabakhshilaktasaraei wants to merge 1 commit into
rezabakhshilaktasaraei wants to merge 1 commit into
Conversation
The name of a checkbox for a screen reader is its label, and a checkbox created without one - beside a poll answer, where the answer stands for the label - had no name at all, with no way to give it one. Fall back to the widget's accessible name when the label is empty.
ilya-fedin
force-pushed
the
master
branch
2 times, most recently
from
September 10, 2026 10:29
f1ac84c to
09f3503
Compare
ilya-fedin
reviewed
Sep 12, 2026
Comment on lines
+212
to
+216
| // A checkbox with no label of its own - beside a poll answer, in a | ||
| // list row - is named by what stands for it, through the widget's | ||
| // accessible name. | ||
| const auto text = _text.toString(); | ||
| return text.isEmpty() ? RpWidget::accessibilityName() : text; |
Contributor
There was a problem hiding this comment.
This is wrong, accessible name always takes the priority over this method
Contributor
Author
|
You're right, QAccessibleWidget::text(Name) already returns the accessible name before Checkbox::accessibilityName() is consulted, so the fallback can never change the result. Verified with NVDA that the poll box radios are named without it; the poll box sets the name on the radio directly and that path is enough. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkbox::accessibilityName()returns the label text, so a checkbox or radio button created without one — the correct answer button beside a poll answer, where the answer stands for the label — had no name for a screen reader and no way to be given one. Fall back to the widget's accessible name when the label is empty. Labelled checkboxes are unchanged.