[WIP] 480 refactor vr#483

Open

luissantosHCIT wants to merge 22 commits into

dcmjs-org:masterfrom

luissantosHCIT:480_refactor_vr

Commits on Mar 10, 2026

fix(BufferStream) Made option optional which looks like it is the expected behavior.
luissantosHCIT
committed
feat(vr-tests) began building test harness for key VR behavior prior to refactoring.
luissantosHCIT
committed
feat(vr-refactor) documented write and refactored its logic to explicitly accept the value parameter.
luissantosHCIT
committed

Commits on Mar 11, 2026

fix(vr-refactor) correct tracking of bytes written by the write method.
luissantosHCIT
committed
feat(vr-tests) updated tests to reflect proper writing of value with multiplicity.
luissantosHCIT
committed
feat(vr-tests) fixed writeBytes test to accomodate strings and values with multiplicity.
luissantosHCIT
committed
feat(vr-refactor) Added documentation strings to make it clear the purpose of the current writeBytes method. This method should be renamed to reflect its validation role better.
luissantosHCIT
committed
feat(vr-refactor) created padding byte lookup table to make it simpler and consistent the selection of the padding character at the base VR class level. It's all based on the VR type anyways.
luissantosHCIT
committed
feat(vr-refactor) refactored write and writeBytes to simplify the logic behind generating multiplicity write length and its validity/verification.
luissantosHCIT
committed
feat(vr-refactor) refactored usage of stream read string methods to use the VR's padded versions since they handle dropping off the padding byte from the returned output thus making reads consisten…
luissantosHCIT
committed
feat(vr-tests) updated tests to reflect the difference of output from the specialized VR's read/write methods and direct reads from the stream. The latter is present to check that the generated raw…
luissantosHCIT
committed
feat(vr-refactor) fixing minor defect in how length is handled based on prior change.
luissantosHCIT
committed
feat(vr-tests) updated test to account for LongString VR type.
luissantosHCIT
committed
feat(vr-tests) updated test to account for SignedInteger VR type.
luissantosHCIT
committed
feat(vr-refactor) making sue we pass a single value as length to the new writeBytes.
luissantosHCIT
committed
feat(vr-refactor) refactored write again to make sure only one length value is emitted.
luissantosHCIT
committed
feat(vr-refactor) changed this.endOffset check to this.size since calling reset resets this value even if the stream contents and size remain. As a result, an error is thrown inappropriately.
luissantosHCIT
committed
feat(vr-refactor) making sure the max length of a binary buffer is passed down to writeBytes and properly pass validity for unbounded buffers.
luissantosHCIT
committed
feat(vr-tests) Added binary OB vr test to make sure we test binary types. Unfortunately, these types write directly via a writeBytes override and thus I make sure here that we use that method when …
luissantosHCIT
committed
feat(vr-refactors) improved logic for determining what the max buffer size should be for a binary vr. The new way addresses an issue with the dicom dict instance ending up with the improper maxLeng…
luissantosHCIT
committed
feat(vr-refactors) Made sure that the _storeRaw acts as returnRaw for the purposes of reading a file. This accommodates the way data-tests checks against raw values. I agree that if a user wants to…
luissantosHCIT
committed
feat(vr-tests) updated the tests in data-tests to reflect the correct raw value when accounting for oddness and pad byte value.
luissantosHCIT
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] 480 refactor vr#483

[WIP] 480 refactor vr#483
luissantosHCIT wants to merge 22 commits into
dcmjs-org:masterfrom
luissantosHCIT:480_refactor_vr

Commits on Mar 10, 2026

fix(BufferStream) Made option optional which looks like it is the expected behavior.

feat(vr-tests) began building test harness for key VR behavior prior to refactoring.

feat(vr-refactor) documented write and refactored its logic to explicitly accept the value parameter.

Commits on Mar 11, 2026

fix(vr-refactor) correct tracking of bytes written by the write method.

feat(vr-tests) updated tests to reflect proper writing of value with multiplicity.

feat(vr-tests) fixed writeBytes test to accomodate strings and values with multiplicity.

feat(vr-refactor) Added documentation strings to make it clear the purpose of the current writeBytes method. This method should be renamed to reflect its validation role better.

feat(vr-refactor) created padding byte lookup table to make it simpler and consistent the selection of the padding character at the base VR class level. It's all based on the VR type anyways.

feat(vr-refactor) refactored write and writeBytes to simplify the logic behind generating multiplicity write length and its validity/verification.

feat(vr-refactor) refactored usage of stream read string methods to use the VR's padded versions since they handle dropping off the padding byte from the returned output thus making reads consisten…

feat(vr-tests) updated tests to reflect the difference of output from the specialized VR's read/write methods and direct reads from the stream. The latter is present to check that the generated raw…

feat(vr-refactor) fixing minor defect in how length is handled based on prior change.

feat(vr-tests) updated test to account for LongString VR type.

feat(vr-tests) updated test to account for SignedInteger VR type.

feat(vr-refactor) making sue we pass a single value as length to the new writeBytes.

feat(vr-refactor) refactored write again to make sure only one length value is emitted.

feat(vr-refactor) changed this.endOffset check to this.size since calling reset resets this value even if the stream contents and size remain. As a result, an error is thrown inappropriately.

feat(vr-refactor) making sure the max length of a binary buffer is passed down to writeBytes and properly pass validity for unbounded buffers.

feat(vr-tests) Added binary OB vr test to make sure we test binary types. Unfortunately, these types write directly via a writeBytes override and thus I make sure here that we use that method when …

feat(vr-refactors) improved logic for determining what the max buffer size should be for a binary vr. The new way addresses an issue with the dicom dict instance ending up with the improper maxLeng…

feat(vr-refactors) Made sure that the _storeRaw acts as returnRaw for the purposes of reading a file. This accommodates the way data-tests checks against raw values. I agree that if a user wants to…

feat(vr-tests) updated the tests in data-tests to reflect the correct raw value when accounting for oddness and pad byte value.