[WIP] 480 refactor vr#483
Open
luissantosHCIT wants to merge 22 commits into
Open
Conversation
…ected behavior. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
…to refactoring. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
…itly accept the value parameter. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
…multiplicity. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
… with multiplicity. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
✅ Deploy Preview for dcmjs2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…rpose of the current writeBytes method. This method should be renamed to reflect its validation role better. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
…r and consistent the selection of the padding character at the base VR class level. It's all based on the VR type anyways. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
…ic behind generating multiplicity write length and its validity/verification. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
…se the VR's padded versions since they handle dropping off the padding byte from the returned output thus making reads consistent with the writes. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
… the specialized VR's read/write methods and direct reads from the stream. The latter is present to check that the generated raw value is correct. The former is there to validate that f(x) => y && g(y) => x in terms of the read/write API. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
Author
|
As I update the unit test harness, I realized that to test the |
…on prior change. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
…new writeBytes. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
… value is emitted. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
…ling reset resets this value even if the stream contents and size remain. As a result, an error is thrown inappropriately. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
…ssed down to writeBytes and properly pass validity for unbounded buffers. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
…pes. Unfortunately, these types write directly via a writeBytes override and thus I make sure here that we use that method when testing binary buffers. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
… size should be for a binary vr. The new way addresses an issue with the dicom dict instance ending up with the improper maxLength on construction in data-tests. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
… the purposes of reading a file. This accommodates the way data-tests checks against raw values. I agree that if a user wants to force a raw read, they should. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
… raw value when accounting for oddness and pad byte value. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #480.
This is my attempt at addressing issues I identified with
ValueRepresentationas well as code cleanup.I am also creating a
test harnesshere to ensure key methods andValueRepresentation typesmaintain the expected behavior pre and post refactor. Perhaps, those test will help others confidently refactorVRfurther in the future.