Skip to content

Refactor not_empty_string macro to fix alias bugs and catch invisible… #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shivasingh4945-tech wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −27
Open

Refactor not_empty_string macro to fix alias bugs and catch invisible… #1082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 14 additions & 27 deletions macros/generic_tests/not_empty_string.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,24 @@
{% test not_empty_string(model, column_name, trim_whitespace=true) %}

{{ return(adapter.dispatch('test_not_empty_string', 'dbt_utils')(model, column_name, trim_whitespace)) }}

{% endtest %}

{% macro default__test_not_empty_string(model, column_name, trim_whitespace=true) %}

with

all_values as (

select


{% if trim_whitespace == true -%}

trim({{ column_name }}) as {{ column_name }}

{%- else -%}

{{ column_name }}

{%- endif %}

with errors as (
select *
from {{ model }}

),

errors as (

select * from all_values
where {{ column_name }} = ''

where
{% if trim_whitespace | as_bool %}

-- OPTIMIZED: Replaces Tabs, Line Feeds, and Carriage Returns
-- with standard spaces in ONE single CPU scan, then trims.
trim(
translate({{ column_name }}, chr(9) || chr(10) || chr(13), ' ')
) = ''

{% else %}
{{ column_name }} = ''
{% endif %}
)

select * from errors
Expand Down
Loading