Refactor not_empty_string macro to fix alias bugs and catch invisible…#1082
Open
shivasingh4945-tech wants to merge 1 commit into
Open
Refactor not_empty_string macro to fix alias bugs and catch invisible…#1082shivasingh4945-tech wants to merge 1 commit into
shivasingh4945-tech wants to merge 1 commit into
Conversation
Author
|
Hi @remigabillet @mjumbewu @haf @zqureshi Would love your feedback on this approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed & why:
as {{ column_name }}), which broke dbt if we tested a nested column (likeuser.email) or a SQL function. I moved the logic straight into theWHEREclause so it works on everything.trim()was missing invisible characters like tabs and newlines. This now catches those so completely blank strings actually fail the test like they are supposed to.replace()functions, it now usestranslate()to swap out all hidden characters in one fast pass.Tested and verified on normal text, empty strings, spaces, tabs, and
NULLs!