Repository navigation
docs: specify the 0.4.0 monorepo engine - #14
Conversation
|
Important Review skippedToo many files! This PR contains 315 files, which is 265 over the limit of 50. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (16)
📒 Files selected for processing (315)
You can disable this status message by setting the WalkthroughThe documentation defines a 0.4.0 Rust engine extraction, a shared erased facade, versioned C ABI, Haskell binding strategy, migration criteria, verification requirements, and threat model. ChangesOne-engine extraction
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d67922a to
79400db
Compare
d337772 to
383b09a
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@adrs/0010-one-engine-multiple-bindings.md`:
- Around line 32-37: Revise the migration rollback policy to archive the
event-sorcery-hs repository as read-only instead of deleting it. Retain a
verified export and restore procedure, including repository metadata and
configuration, until the defined retention period expires and rollback approval
is granted; remove the claim that a local clone can recreate the remote
repository.
In `@SPEC.md`:
- Around line 253-258: Expand the “Error identity” section in SPEC.md to define
stable versioned numeric error codes for each required error class, a canonical
bounded schema for deterministic details, and explicit redaction rules ensuring
opaque payload bytes are excluded from errors and logs. Require all bindings to
preserve these codes, details, and redaction guarantees across the ABI.
- Around line 236-243: Define one shared set of concrete normative ABI limits in
SPEC.md at the framework encoding section, covering input/output byte sizes,
nesting depth, page and event counts, and payload sizes, with deterministic
rejection behavior. Update docs/threat-model-0.4.md in the denial-of-service
controls and abuse tests to reference those exact specification limits directly
rather than duplicating or leaving them undefined.
- Around line 216-223: Update the store lifecycle semantics in SPEC.md around
the close/finalizer requirements to define a linearization rule: once explicit
close or the ForeignPtr finalizer begins, reject all newly started calls, allow
already in-flight calls to complete, and wait for them to drain before
destroying the store handle. Preserve idempotence when close and finalization
race, ensuring destruction occurs exactly once.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 34914b1a-6859-40a7-9db7-dd6a4fb66e31
📒 Files selected for processing (4)
ROADMAP.mdSPEC.mdadrs/0010-one-engine-multiple-bindings.mddocs/threat-model-0.4.md
📜 Review details
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{rs,toml,sql,md}
📄 CodeRabbit inference engine (AGENTS.md)
Read SPEC.md and docs/domain.md before doing work; update README.md and relevant docs when implementation or architecture changes.
Files:
ROADMAP.mdadrs/0010-one-engine-multiple-bindings.mdSPEC.mddocs/threat-model-0.4.md
**/*
📄 CodeRabbit inference engine (AGENTS.md)
**/*: Generated files must be placed under .tmp/; do not add ad-hoc top-level generated entries to .gitignore.
Do not read secret-bearing files such as .env*, credentials.json, *.key, *.pem, *.p12, or *.pfx without explicit permission.
Never bypass, disable, or suppress quality-control mechanisms without explicit permission; fix lint and test failures at their root.
Before handover, review the diff, revert unjustified changes, and check for scope creep.
Files:
ROADMAP.mdadrs/0010-one-engine-multiple-bindings.mdSPEC.mddocs/threat-model-0.4.md
*
⚙️ CodeRabbit configuration file
Focus on providing constructive criticism. Whenever you see a suboptimal approach, suggest more idiomatic or robust alternative(s). Flag potential footguns. Suggest FP alternatives to mutable/imperative code. Point out architectural flaws like leaky abstractions, tight coupling, wrong level of abstraction, poor type modeling, over-abstraction, unclear domain boundaries. Code should generally be organized based on business concerns rather than technical aspects - suggest improvements if you find violations. Point out gaps in test coverage but suggest tests that are not too coupled to the implementation and actually test domain invariants and business logic
Files:
ROADMAP.mdSPEC.md
**/*.md
⚙️ CodeRabbit configuration file
Focus on the contents of the docs and not on cosmetic things like markdown formatting. We use markdown files for various docs including but not limited to guidelines for AI contributors (AGENTS.md), project overview and instructions for human contributors (README.md), and topic-focused references under docs/ (cqrs.md, sqlx.md, ttdd.md). Think about the target audience of a document when deciding what comment to leave. For instructions, suggest better rules and guidelines and point out missing instructions. For topic references, suggest improvements that would make non-obvious framework behavior or pitfalls easier to discover. In all cases, flag needless bloat, prefer clear concise writing, and consider the structure of the document and order of the sections
Files:
ROADMAP.mdadrs/0010-one-engine-multiple-bindings.mdSPEC.mddocs/threat-model-0.4.md
🪛 LanguageTool
SPEC.md
[style] ~212-~212: Consider replacing this word to strengthen your wording.
Context: ... header. The header is a build artifact and MUST NOT be hand-maintained. ### Handl...
(AND_THAT)
[style] ~222-~222: This phrase is redundant. Use simply “import”.
Context: ...askell imports for those calls MUST use foreign import capi safe. Only constant-time function...
(FOREIGN_IMPORT)
[uncategorized] ~337-~337: The official name of this software platform is spelled with a capital “H”.
Context: ... The flake consumes the shared external github:dataclique/but.nix library rather than...
(GITHUB)
[grammar] ~346-~346: Ensure spelling is correct
Context: ...e CI checks and MUST NOT be git hooks. Fourmolu uses the repository configuration and a...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~396-~396: Use a hyphen to join words.
Context: ...d generated header. 6. Bring the Haskell typed surface into the monorepo and repl...
(QB_NEW_EN_HYPHEN)
🔇 Additional comments (2)
ROADMAP.md (1)
1-42: LGTM!SPEC.md (1)
161-178: 🗄️ Data Integrity & IntegrationNo conflict in the domain effect shape. The “events or one declared job dispatch” wording matches the binding-side API; the atomic event+durable-job requirement is already carried by the engine’s commit request and persistence contract. This comment should be dropped.
> Likely an incorrect or invalid review comment.
383b09a to
5a3087b
Compare
5a3087b to
4150c20
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/threat-model-0.4.md`:
- Around line 35-37: Clarify the abuse-test requirement by defining the
contract-stub harness and its expected pre-implementation failure, or replace
“contract stubs” with a deterministic test-first rule requiring tests to fail
before implementation and pass afterward. Update the surrounding requirement
without changing the separate dependency advisory-review and build-script
inspection criteria.
In `@SPEC.md`:
- Around line 235-239: Update the Versioning ABI contract to define
minor-version compatibility: require bindings to declare and validate a minimum
supported minor version, or specify an equivalent capability-negotiation
mechanism. Ensure libraries lacking required additive exports are rejected
before any calls begin, while preserving the existing major-version mismatch
rule.
- Around line 376-382: The documented Nix dependency contract is inconsistent
with the flake’s pinned input. Align the `Build and repository contract` section
of `SPEC.md` with the actual `flake.nix` dependency graph, or update the flake
pin to match the documented `github:dataclique/but.nix`; ensure both describe
the same external library source.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: c3f72832-8483-48c4-9bdd-6feba19adcac
📒 Files selected for processing (4)
ROADMAP.mdSPEC.mdadrs/0010-one-engine-multiple-bindings.mddocs/threat-model-0.4.md
📜 Review details
⏰ Context from checks skipped due to timeout. (6)
- GitHub Check: test
- GitHub Check: check
- GitHub Check: fmt
- GitHub Check: examples
- GitHub Check: clippy
- GitHub Check: hooks
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{rs,toml,sql,md}
📄 CodeRabbit inference engine (AGENTS.md)
Read SPEC.md and docs/domain.md before doing work; update README.md and relevant docs when implementation or architecture changes.
Files:
docs/threat-model-0.4.mdROADMAP.mdadrs/0010-one-engine-multiple-bindings.mdSPEC.md
**/*
📄 CodeRabbit inference engine (AGENTS.md)
**/*: Generated files must be placed under .tmp/; do not add ad-hoc top-level generated entries to .gitignore.
Do not read secret-bearing files such as .env*, credentials.json, *.key, *.pem, *.p12, or *.pfx without explicit permission.
Never bypass, disable, or suppress quality-control mechanisms without explicit permission; fix lint and test failures at their root.
Before handover, review the diff, revert unjustified changes, and check for scope creep.
Files:
docs/threat-model-0.4.mdROADMAP.mdadrs/0010-one-engine-multiple-bindings.mdSPEC.md
**/*.md
⚙️ CodeRabbit configuration file
Focus on the contents of the docs and not on cosmetic things like markdown formatting. We use markdown files for various docs including but not limited to guidelines for AI contributors (AGENTS.md), project overview and instructions for human contributors (README.md), and topic-focused references under docs/ (cqrs.md, sqlx.md, ttdd.md). Think about the target audience of a document when deciding what comment to leave. For instructions, suggest better rules and guidelines and point out missing instructions. For topic references, suggest improvements that would make non-obvious framework behavior or pitfalls easier to discover. In all cases, flag needless bloat, prefer clear concise writing, and consider the structure of the document and order of the sections
Files:
docs/threat-model-0.4.mdROADMAP.mdadrs/0010-one-engine-multiple-bindings.mdSPEC.md
*
⚙️ CodeRabbit configuration file
Focus on providing constructive criticism. Whenever you see a suboptimal approach, suggest more idiomatic or robust alternative(s). Flag potential footguns. Suggest FP alternatives to mutable/imperative code. Point out architectural flaws like leaky abstractions, tight coupling, wrong level of abstraction, poor type modeling, over-abstraction, unclear domain boundaries. Code should generally be organized based on business concerns rather than technical aspects - suggest improvements if you find violations. Point out gaps in test coverage but suggest tests that are not too coupled to the implementation and actually test domain invariants and business logic
Files:
ROADMAP.mdSPEC.md
🪛 LanguageTool
SPEC.md
[style] ~212-~212: Consider replacing this word to strengthen your wording.
Context: ... header. The header is a build artifact and MUST NOT be hand-maintained. ### Handl...
(AND_THAT)
[style] ~229-~229: This phrase is redundant. Use simply “import”.
Context: ...askell imports for those calls MUST use foreign import capi safe. Only constant-time function...
(FOREIGN_IMPORT)
[uncategorized] ~378-~378: The official name of this software platform is spelled with a capital “H”.
Context: ... The flake consumes the shared external github:dataclique/but.nix library rather than...
(GITHUB)
[grammar] ~387-~387: Ensure spelling is correct
Context: ...e CI checks and MUST NOT be git hooks. Fourmolu uses the repository configuration and a...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~437-~437: Use a hyphen to join words.
Context: ...d generated header. 6. Bring the Haskell typed surface into the monorepo and repl...
(QB_NEW_EN_HYPHEN)
🔇 Additional comments (4)
SPEC.md (2)
428-444: Do not make remote repository deletion the rollback boundary.Step 8 deletes
event-sorcery-hswhile retaining only an export and local clone. The migration needs a read-only archive plus a verified export/restore procedure retained for a defined period before deletion is approved.
372-374: 🩺 Stability & AvailabilityMake the GHC capability-release guarantee implementable.
foreign import capi safeis specified, but the document separately requires every potentially blocking call to release a GHC capability. Define the adapter/runtime mechanism and add a test proving blocking store calls do not monopolize capabilities, including close/finalizer races.adrs/0010-one-engine-multiple-bindings.md (1)
32-41: Retain a read-only archive instead of deleting the remote repository.The export and disposable-repository restore test are useful, but deletion remains the rollback plan and no retention period is defined. Archive
event-sorcery-hsread-only and retain the verified export/restore procedure until rollback approval and the documented retention period expire.ROADMAP.md (1)
1-42: LGTM!
4150c20 to
287bf0d
Compare
287bf0d to
a048fdf
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@adrs/0010-one-engine-multiple-bindings.md`:
- Around line 32-41: Replace the final deletion of event-sorcery-hs in
adrs/0010-one-engine-multiple-bindings.md lines 32-41 with read-only archival,
retaining the verified export/restore procedure until rollback approval and the
defined retention period expire. Update SPEC.md lines 451-452 to make repository
archival, rather than deletion, the migration step; preserve the existing
migration order and backup/restore requirements.
In `@SPEC.md`:
- Around line 293-302: The ABI_MISMATCH canonical detail in the specification
must include minor-version information. Update the ABI_MISMATCH entry to report
expected major, minimum minor, actual major, and actual minor, preserving the
existing representation and ordering conventions used by the version-negotiation
contract.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 7083781a-818d-4430-bb99-469806f1a078
📒 Files selected for processing (4)
ROADMAP.mdSPEC.mdadrs/0010-one-engine-multiple-bindings.mddocs/threat-model-0.4.md
📜 Review details
⏰ Context from checks skipped due to timeout. (6)
- GitHub Check: examples
- GitHub Check: clippy
- GitHub Check: test
- GitHub Check: fmt
- GitHub Check: check
- GitHub Check: hooks
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{rs,toml,sql,md}
📄 CodeRabbit inference engine (AGENTS.md)
Read SPEC.md and docs/domain.md before doing work; update README.md and relevant docs when implementation or architecture changes.
Files:
ROADMAP.mdadrs/0010-one-engine-multiple-bindings.mddocs/threat-model-0.4.mdSPEC.md
**/*
📄 CodeRabbit inference engine (AGENTS.md)
**/*: Generated files must be placed under .tmp/; do not add ad-hoc top-level generated entries to .gitignore.
Do not read secret-bearing files such as .env*, credentials.json, *.key, *.pem, *.p12, or *.pfx without explicit permission.
Never bypass, disable, or suppress quality-control mechanisms without explicit permission; fix lint and test failures at their root.
Before handover, review the diff, revert unjustified changes, and check for scope creep.
Files:
ROADMAP.mdadrs/0010-one-engine-multiple-bindings.mddocs/threat-model-0.4.mdSPEC.md
*
⚙️ CodeRabbit configuration file
Focus on providing constructive criticism. Whenever you see a suboptimal approach, suggest more idiomatic or robust alternative(s). Flag potential footguns. Suggest FP alternatives to mutable/imperative code. Point out architectural flaws like leaky abstractions, tight coupling, wrong level of abstraction, poor type modeling, over-abstraction, unclear domain boundaries. Code should generally be organized based on business concerns rather than technical aspects - suggest improvements if you find violations. Point out gaps in test coverage but suggest tests that are not too coupled to the implementation and actually test domain invariants and business logic
Files:
ROADMAP.mdSPEC.md
**/*.md
⚙️ CodeRabbit configuration file
Focus on the contents of the docs and not on cosmetic things like markdown formatting. We use markdown files for various docs including but not limited to guidelines for AI contributors (AGENTS.md), project overview and instructions for human contributors (README.md), and topic-focused references under docs/ (cqrs.md, sqlx.md, ttdd.md). Think about the target audience of a document when deciding what comment to leave. For instructions, suggest better rules and guidelines and point out missing instructions. For topic references, suggest improvements that would make non-obvious framework behavior or pitfalls easier to discover. In all cases, flag needless bloat, prefer clear concise writing, and consider the structure of the document and order of the sections
Files:
ROADMAP.mdadrs/0010-one-engine-multiple-bindings.mddocs/threat-model-0.4.mdSPEC.md
🪛 LanguageTool
SPEC.md
[style] ~219-~219: Consider replacing this word to strengthen your wording.
Context: ... header. The header is a build artifact and MUST NOT be hand-maintained. ### Handl...
(AND_THAT)
[style] ~236-~236: This phrase is redundant. Use simply “import”.
Context: ...askell imports for those calls MUST use foreign import capi safe. Only constant-time function...
(FOREIGN_IMPORT)
[uncategorized] ~389-~389: The official name of this software platform is spelled with a capital “H”.
Context: ... The flake consumes the shared external github:dataclique/but.nix library rather than...
(GITHUB)
[grammar] ~398-~398: Ensure spelling is correct
Context: ...e CI checks and MUST NOT be git hooks. Fourmolu uses the repository configuration and a...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~448-~448: Use a hyphen to join words.
Context: ...d generated header. 6. Bring the Haskell typed surface into the monorepo and repl...
(QB_NEW_EN_HYPHEN)
🔇 Additional comments (6)
ROADMAP.md (1)
1-42: LGTM!SPEC.md (3)
1-119: LGTM!Also applies to: 124-222, 227-292, 303-450, 453-470
120-123: 🗄️ Data Integrity & Integration | 🏗️ Heavy liftDefine and test claim-handle validation consistently.
The ABI contract must make opaque handles non-authoritative caller input: the engine must validate ownership and job/stream/claim scope before any lifecycle mutation.
SPEC.md#L120-L123: specify authenticity, store ownership, job/stream binding, and stable rejection behavior.docs/threat-model-0.4.md#L27-L27: add malformed, forged, wrong-job, wrong-stream, and cross-store handle abuse tests.
223-226: 🩺 Stability & Availability | 🏗️ Heavy liftDefine invalid and repeated buffer-release behavior.
“Freed exactly once” is incomplete without a deterministic rule for
NULL, foreign, and already-released pointers.
SPEC.md#L223-L226: define the memory-safe result of invalid or repeated release.docs/threat-model-0.4.md#L30-L30: assert that behavior in the double-free abuse test.adrs/0010-one-engine-multiple-bindings.md (1)
1-31: LGTM!Also applies to: 43-58
docs/threat-model-0.4.md (1)
1-26: LGTM!Also applies to: 28-29, 31-37
a048fdf to
3608117
Compare
3608117 to
c5368fd
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/threat-model-0.4.md`:
- Line 27: Update the Tampering threat entry to describe a forged or stale claim
handle rather than a forged lease token. Require validation and rejection
against the existing ClaimId and persisted claim sequence fence, preserving the
SPEC.md claim-fencing model and boundary-value stale-handle tests.
In `@SPEC.md`:
- Around line 239-240: Update the export panic-handling and poisoned-handle
behavior described in SPEC.md so poisoning blocks only data operations, while
close/finalization remains callable, idempotent, and able to drain and destroy
the handle exactly once. Preserve the requirement that panics never unwind
across the C boundary.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: c112cad9-e017-4899-a40a-f76d6a28448d
📒 Files selected for processing (4)
ROADMAP.mdSPEC.mdadrs/0010-one-engine-multiple-bindings.mddocs/threat-model-0.4.md
📜 Review details
⏰ Context from checks skipped due to timeout. (6)
- GitHub Check: examples
- GitHub Check: fmt
- GitHub Check: hooks
- GitHub Check: test
- GitHub Check: check
- GitHub Check: clippy
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{rs,toml,sql,md}
📄 CodeRabbit inference engine (AGENTS.md)
Read SPEC.md and docs/domain.md before doing work; update README.md and relevant docs when implementation or architecture changes.
Files:
ROADMAP.mddocs/threat-model-0.4.mdadrs/0010-one-engine-multiple-bindings.mdSPEC.md
**/*
📄 CodeRabbit inference engine (AGENTS.md)
**/*: Generated files must be placed under .tmp/; do not add ad-hoc top-level generated entries to .gitignore.
Do not read secret-bearing files such as .env*, credentials.json, *.key, *.pem, *.p12, or *.pfx without explicit permission.
Never bypass, disable, or suppress quality-control mechanisms without explicit permission; fix lint and test failures at their root.
Before handover, review the diff, revert unjustified changes, and check for scope creep.
Files:
ROADMAP.mddocs/threat-model-0.4.mdadrs/0010-one-engine-multiple-bindings.mdSPEC.md
*
⚙️ CodeRabbit configuration file
Focus on providing constructive criticism. Whenever you see a suboptimal approach, suggest more idiomatic or robust alternative(s). Flag potential footguns. Suggest FP alternatives to mutable/imperative code. Point out architectural flaws like leaky abstractions, tight coupling, wrong level of abstraction, poor type modeling, over-abstraction, unclear domain boundaries. Code should generally be organized based on business concerns rather than technical aspects - suggest improvements if you find violations. Point out gaps in test coverage but suggest tests that are not too coupled to the implementation and actually test domain invariants and business logic
Files:
ROADMAP.mdSPEC.md
**/*.md
⚙️ CodeRabbit configuration file
Focus on the contents of the docs and not on cosmetic things like markdown formatting. We use markdown files for various docs including but not limited to guidelines for AI contributors (AGENTS.md), project overview and instructions for human contributors (README.md), and topic-focused references under docs/ (cqrs.md, sqlx.md, ttdd.md). Think about the target audience of a document when deciding what comment to leave. For instructions, suggest better rules and guidelines and point out missing instructions. For topic references, suggest improvements that would make non-obvious framework behavior or pitfalls easier to discover. In all cases, flag needless bloat, prefer clear concise writing, and consider the structure of the document and order of the sections
Files:
ROADMAP.mddocs/threat-model-0.4.mdadrs/0010-one-engine-multiple-bindings.mdSPEC.md
🪛 LanguageTool
SPEC.md
[style] ~219-~219: Consider replacing this word to strengthen your wording.
Context: ... header. The header is a build artifact and MUST NOT be hand-maintained. ### Handl...
(AND_THAT)
[style] ~236-~236: This phrase is redundant. Use simply “import”.
Context: ...askell imports for those calls MUST use foreign import capi safe. Only constant-time function...
(FOREIGN_IMPORT)
[uncategorized] ~394-~394: The official name of this software platform is spelled with a capital “H”.
Context: ... The flake consumes the shared external github:dataclique/but.nix library rather than...
(GITHUB)
[grammar] ~403-~403: Ensure spelling is correct
Context: ...e CI checks and MUST NOT be git hooks. Fourmolu uses the repository configuration and a...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~453-~453: Use a hyphen to join words.
Context: ...d generated header. 6. Bring the Haskell typed surface into the monorepo and repl...
(QB_NEW_EN_HYPHEN)
🔇 Additional comments (5)
SPEC.md (3)
456-457: 🗄️ Data Integrity & IntegrationArchive the superseded repository instead of deleting it.
The migration still makes remote deletion the final step. Replace it with read-only archival plus a verified export/restore procedure, explicit retention, and rollback approval.
223-233: 🩺 Stability & AvailabilityHandle invalidation is already specified. The ABI leaves a closed owner value that absorbs later closes without touching freed memory, so extra pointer-null/tombstone semantics are not required here.
> Likely an incorrect or invalid review comment.
429-435: 🗄️ Data Integrity & IntegrationNo shared payload fixture is needed here. Domain payload bytes are intentionally opaque, so cross-binding conformance should focus on framework values and error identity.
> Likely an incorrect or invalid review comment.adrs/0010-one-engine-multiple-bindings.md (1)
32-41: 🗄️ Data Integrity & IntegrationArchive the superseded repository instead of deleting it.
Deleting the remote repository is not a reversible rollback plan; a local clone cannot restore issues, pull requests, settings, protections, or other remote metadata. Use read-only archival with a verified export/restore procedure, explicit retention, and rollback approval.
ROADMAP.md (1)
1-42: LGTM!
b49fd57 to
fe7bfd9
Compare
fe7bfd9 to
13284b9
Compare
13284b9 to
34d4e94
Compare
GitButler-Conflict: This is a GitButler-managed conflicted commit. Files are auto-resolved
using the "ours" side. The commit tree contains additional directories:
.conflict-side-0 — our tree
.conflict-side-1 — their tree
.conflict-base-0 — the merge base tree
.auto-resolution — the auto-resolved tree
.conflict-files — metadata about conflicted files
To manually resolve, check out this commit, remove the directories
listed above, resolve the conflicts, and amend the commit.
34d4e94 to
9d6593d
Compare
1 participant
Defines the 0.4.0 extraction contract: the shared engine must be carved out of the existing cqrs-es, Apalis, sqlite-es, SQLx, and SQLite implementation. It preserves the current Rust API and job/dispatch semantics, prohibits parallel Rust or Haskell framework implementations, and makes deterministic CBOR an ABI encoding rather than a storage rewrite.
Updates ADR-0010 and the roadmap so characterization of current behavior precedes facade extraction.
Part of #9.
This is part 1 of 32 in a stack made with GitButler:
Summary by CodeRabbit