Skip to content

Fix method redefined warning for log_regexp_timeout= (Ruby 4.0+) #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dominion525 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix method redefined warning for log_regexp_timeout= (Ruby 4.0+) #721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/ruby_llm/configuration.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ def instance_variables
super.reject { |ivar| ivar.to_s.match?(/_id|_key|_secret|_token$/) }
end

remove_method :log_regexp_timeout=
def log_regexp_timeout=(value)
if value.nil?
@log_regexp_timeout = nil
Expand Down
7 changes: 7 additions & 0 deletions spec/ruby_llm/configuration_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,11 @@
)
end
end

describe 'method redefinition warnings' do
it 'does not emit method redefined warning for log_regexp_timeout=' do
warnings = `#{RbConfig.ruby} -W -e 'require "ruby_llm"' 2>&1`
expect(warnings).not_to include('method redefined')
end
end
end