Fix method redefined warning for log_regexp_timeout= (Ruby 4.0+)#721
Open
dominion525 wants to merge 1 commit intocrmne:mainfrom
Open
Fix method redefined warning for log_regexp_timeout= (Ruby 4.0+)#721dominion525 wants to merge 1 commit intocrmne:mainfrom
dominion525 wants to merge 1 commit intocrmne:mainfrom
Conversation
Remove the attr_accessor-generated setter before redefining it with the custom setter to prevent the warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
On Ruby 4.0+,
require "ruby_llm"emits:The
optionclass method generates a setter viaattr_accessor, which is thenoverridden by the custom
log_regexp_timeout=setter. This addsremove_methodbefore the redefinition to suppress the warning. A regression spec is included.
Type of change
Scope check
Quality check
overcommit --installand all hooks passbundle exec rspecmodels.json,aliases.json)AI-generated code
API changes