improve(E2E): wire quickpick titles into Quickpick call sites - #3443
Draft
Dave Shoup (shouples) wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary of Changes
Note
Stacked on top of #3442, which adds the
titlePatterncapability to theQuickpickpage object. Review and merge that one first; this PR's diff is only the call-site wiring.Previously, an E2E step could interact with the wrong quickpick (for example, a transient "Loading Kafka clusters..." placeholder) before the real one appeared, because nothing verified which quickpick was on screen. This PR closes that gap by wiring the
titlePatternargument added in #3442 into the ~26 existingnew Quickpick(...)call sites, so each step now asserts on the exact title the quickpick renders before interacting with it.Titles were traced to their source literals in
src/quickpicks/andsrc/commands/(e.g.Select a Kafka cluster,Choose a schema type,Upload Flink Artifact). The two schema-kind pickers use a dynamic title (Producing to ${topic.name}: Select Schema Kind(s)...), so those pass aRegExpinstead of a string. Call sites with no title (project-template picker, connection-type picker) or backed by a VS Code built-in (command palette, language-mode picker) were left untitled on purpose.Click-testing instructions
Not applicable (E2E test infrastructure with no user-facing behavior). This should be validated by a full E2E run on CI.
Optional: Any additional details or context that should be provided?
npx gulp check, ESLint, and Prettier pass on the changed files. As with the parent PR, the full Playwright E2E suite needs Docker, the sidecar, and Electron, so it was not run locally; a CI E2E run is the real verification that each wired title resolves.Quickpick. Deliberately out of scope: wiringtitlePatterninto the adjacentInputBoxcall sites. This PR applies it broadly toQuickpicks (unlikeInputBox, which uses it in only 1 call site) because multiple quickpicks can be visible or transitioning at once.Relates to #2740
Pull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
Release notes