improve(E2E): add Quickpick title filter and visibility gate - #3442
Draft
Dave Shoup (shouples) wants to merge 1 commit into
Draft
improve(E2E): add Quickpick title filter and visibility gate#3442Dave Shoup (shouples) wants to merge 1 commit into
Quickpick title filter and visibility gate#3442Dave Shoup (shouples) wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Improves the Quickpick E2E page object with title-based filtering and centralized visibility waits.
Changes:
- Adds optional
titlePatternfiltering. - Adds
waitForVisible()before interactions. - Preserves existing constructor compatibility.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Summary of Changes
The
QuickpickE2E page object always grabs the first.quick-input-widgeton the page and leaves each caller to assert it's visible before typing or clicking into it. Only one quickpick renders at a time, so this mostly works, but it's fragile: a test can act on a quickpick that hasn't rendered yet (a source of intermittent E2E flakes), and there's no way to say which quickpick a step expects. ~35 call sites repeat their owntoBeVisible()gate to work around this.This PR makes two changes to
tests/e2e/objects/quickInputs/Quickpick.ts:titlePattern?: string | RegExpconstructor argument that filters the widget by its.quick-input-title, mirroring the siblingInputBoxpage object.waitForVisible()helper thatconfirm(),cancel(), andselectItemByText()call before interacting, moving the visibility gate into the page object instead of every call site.titlePatternis optional, so all existingnew Quickpick(page)call sites keep working unchanged.Click-testing instructions
Not applicable (E2E test infrastructure with no user-facing behavior).
Optional: Any additional details or context that should be provided?
npx gulp check, ESLint, and Prettier all pass on the changed file. The full Playwright E2E suite (which is what actually exercises this page object) needs Docker, the sidecar, and Electron, so it was not run on this branch; please run E2E before merging.InputBoxthe samewaitForVisible()gate for parity, and dropping the now-redundant manualtoBeVisible()assertions from the call sites that no longer need them.Closes #2740
Pull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
Release notes