BUG: Fix ctkLanguageComboBox locale normalization and selection by hjmjohnson · Pull Request #1400 · commontk/CTK

hjmjohnson · 2026-03-31T12:32:23Z

Summary

setDefaultLanguage() stored the raw input string without validation or normalization, causing bare language codes like "en" to not be expanded to "en_US", and invalid codes like "xx" to be accepted
Normalize locale codes through QLocale — codes that map to "C" (unrecognized) are rejected
Fix updateLanguageItems() to fall back to selecting the default language item when no prior selection exists, so currentLanguage() returns the correct value after the first setDefaultLanguage() call

Test plan

ctkLanguageComboBoxTest passes on both Qt5 and Qt6 (all 12 sub-tests)
Cherry-picks cleanly onto current master

🤖 Generated with Claude Code

hjmjohnson · 2026-03-31T12:34:02Z

@lassoan, I am NOT very familiar with locales. This looks reasonable to me, but I am not knowledgeable about the nuances.

I do know that tests were failing, and now they pass. It would be great if you, or someone you know, could review the proposed change here.

lassoan · 2026-04-01T20:42:42Z

Thanks for the fix. I'll test this. The topic of language codes is surprisingly complex.

hjmjohnson · 2026-04-03T16:49:02Z

/validate-ctk-pr report superseded by a newer validation run.

hjmjohnson · 2026-04-03T16:58:35Z

CTK Validation Report for PR #1400

Date: 2026-04-03T16:58:30Z
Platform: Linux 6.17.0-1012-oem x86_64

Role	CTK Hash	Commit
Proposed	`a708f388`	`429d94d` (HEAD -> fix-non-pod-constexpr, pushorigin/fix-non-pod-constexpr) STYLE: Fix static ctkLogger in public PythonQt decorator headers
Reference	`935c4e04`	`935c4e0` (HEAD) ENH: Add refreshBrowser to the DICOM visual browser

✅ = 0 errors/failures (clean) | ⚠️ = warnings increased vs reference | 🚫 = new errors or test failures vs reference

Validation Actions Performed

#	Action	Scope	Qt	Proposed (`a708f388`)	Reference (`935c4e04`)
1	Build	CTK standalone	Qt5	0 errors, 53 warnings ✅ ⚠️	0 errors, 21 warnings
2	Build	CTK standalone	Qt6	0 errors, 57 warnings ✅ ⚠️	2 errors, 3 warnings
3	Test	CTK standalone	Qt5	267/280 passed, 13 failed	255/280 passed, 25 failed
4	Test	CTK standalone	Qt6	245/255 passed, 10 failed	245/255 passed, 10 failed
5	Build	CTK-in-Slicer (clean)	Qt5	0 errors, 187 warnings ✅	0 errors, 187 warnings
6	Build	Slicer inner build	Qt5	0 errors, 0 warnings ✅ ✅	0 errors, 0 warnings
7	Test	Slicer inner build	Qt5	661/670 passed, 9 failed	661/670 passed, 9 failed

⚠️ CTK standalone Qt5: 32 new warnings (21 → 53)

By category:

Count	Category
27	`[-Wold-style-cast`
26	`[-Wunused-variable`

By source:

Count	Source	Origin
15	`/usr/include/python3.14/pyport.h`	Python headers (external)
6	`/usr/include/python3.14/object.h`	Python headers (external)
6	`/home/johnsonhj/src/CTK/cmake-build-clazy-qt5/CMakeExternals/Install/include/PythonQt/PythonQtInstanceWrapper.h`	PythonQt (external)
1	`Libs/Widgets/ctkThumbnailLabel.cpp`	CTK source
1	`Libs/Widgets/ctkSettingsDialog.cpp`	CTK source
1	`Libs/Widgets/ctkModalityWidget.cpp`	CTK source
1	`Libs/Widgets/ctkMaterialPropertyWidget.cpp`	CTK source
1	`Libs/Widgets/ctkFlowLayout.cpp`	CTK source
1	`Libs/Widgets/ctkCrosshairLabel.cpp`	CTK source
1	`Libs/Visualization/VTK/Widgets/ctkVTKThresholdWidget.cpp`	CTK source
1	`Libs/Visualization/VTK/Widgets/ctkVTKMagnifyView.cpp`	CTK source
1	`Libs/Visualization/VTK/Widgets/ctkVTKAbstractView.cpp`	CTK source
1	`Libs/Visualization/VTK/Core/ctkVTKScalarsToColorsUtils.cpp`	CTK source
1	`Libs/DICOM/Widgets/ctkDICOMQueryWidget.cpp`	CTK source
1	`Libs/DICOM/Widgets/ctkDICOMObjectListWidget.cpp`	CTK source
1	`Libs/DICOM/Widgets/ctkDICOMAppWidget.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMThumbnailGeneratorJob.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMTester.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMStorageListenerJob.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMServer.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMRetrieveJob.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMQueryJob.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMJobResponseSet.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMJob.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMInserterJob.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMFilterProxyModel.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMEchoJob.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMDisplayedFieldGenerator.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMAbstractThumbnailGenerator.cpp`	CTK source

⚠️ CTK standalone Qt6: 54 new warnings (3 → 57)

By category:

Count	Category
30	`[-Wunused-variable`
27	`[-Wold-style-cast`

By source:

Count	Source	Origin
15	`/usr/include/python3.14/pyport.h`	Python headers (external)
6	`/usr/include/python3.14/object.h`	Python headers (external)
6	`/home/johnsonhj/src/CTK/cmake-build-clazy-qt6/CMakeExternals/Install/include/PythonQt/PythonQtInstanceWrapper.h`	PythonQt (external)
1	`Libs/Widgets/ctkThumbnailLabel.cpp`	CTK source
1	`Libs/Widgets/ctkSettingsDialog.cpp`	CTK source
1	`Libs/Widgets/ctkModalityWidget.cpp`	CTK source
1	`Libs/Widgets/ctkMaterialPropertyWidget.cpp`	CTK source
1	`Libs/Widgets/ctkFlowLayout.cpp`	CTK source
1	`Libs/Widgets/ctkCrosshairLabel.cpp`	CTK source
1	`Libs/Visualization/VTK/Widgets/ctkVTKVolumePropertyWidget.cpp`	CTK source
1	`Libs/Visualization/VTK/Widgets/ctkVTKThresholdWidget.cpp`	CTK source
1	`Libs/Visualization/VTK/Widgets/ctkVTKScalarsToColorsWidget.cpp`	CTK source
1	`Libs/Visualization/VTK/Widgets/ctkVTKScalarsToColorsView.cpp`	CTK source
1	`Libs/Visualization/VTK/Widgets/ctkVTKMagnifyView.cpp`	CTK source
1	`Libs/Visualization/VTK/Widgets/ctkVTKChartView.cpp`	CTK source
1	`Libs/Visualization/VTK/Widgets/ctkVTKAbstractView.cpp`	CTK source
1	`Libs/Visualization/VTK/Core/ctkVTKScalarsToColorsUtils.cpp`	CTK source
1	`Libs/DICOM/Widgets/ctkDICOMQueryWidget.cpp`	CTK source
1	`Libs/DICOM/Widgets/ctkDICOMObjectListWidget.cpp`	CTK source
1	`Libs/DICOM/Widgets/ctkDICOMAppWidget.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMThumbnailGeneratorJob.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMTester.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMStorageListenerJob.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMServer.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMRetrieveJob.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMQueryJob.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMJobResponseSet.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMJob.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMInserterJob.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMFilterProxyModel.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMEchoJob.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMDisplayedFieldGenerator.cpp`	CTK source
1	`Libs/DICOM/Core/ctkDICOMAbstractThumbnailGenerator.cpp`	CTK source

CTK-in-Slicer Build Detail (classified warnings)

Source	Proposed warnings	Reference warnings
CTK source code	1	1
CTK dependencies	186	186
Slicer (CTK-related)	0 ✅	0
Slicer (own code)	0 ✅	0

Slicer Test Detail (classified failures)

Category	Proposed (`a708f388`)	Reference (`935c4e04`)
CTK-related failures	0 ✅	0
Slicer-own failures	0 ✅	0
Total failed	9	9

CTK Test Failures (proposed a708f388)

Qt5 (13 failures):

Test	Status	Related PR/Issue
`ctkFontButtonTest`	🔄 Timeout	#1395 — WIP: Fix ctkFontButtonTest hang and disable stale modal dialog tests
`ctkLanguageComboBoxTest`	🔄 Failed	#1400 — BUG: Fix ctkLanguageComboBox locale normalization and selection
`ctkWidgetsUtilsTestGrabWidget`	🖥️ Failed	— — Requires OpenGL display — fails in headless environments
`ctkColorPickerButtonEventTranslatorPlayerTest1`	🔄 Timeout	#1395 — Modal dialog timeout — addressed in test fix PR
`ctkDirectoryButtonEventTranslatorPlayerTest1`	🔄 Timeout	#1395 — Modal dialog timeout — addressed in test fix PR
`ctkFileDialogEventTranslatorPlayerTest1`	🔄 Timeout	#1395 — Modal dialog timeout — addressed in test fix PR
`ctkMenuComboBoxEventTranslatorPlayerTest1`	🔄 Failed	#1395 — Modal dialog event translator failure
`vtkLightBoxRendererManagerTest1`	🖥️ SEGFAULT	— — GPU/GLSL infrastructure — SEGFAULT in headless environments
`ctkVTKMagnifyViewTest2OddOdd`	🖥️ Failed	— — VTK OpenGL render — fails without GPU
`ctkVTKMagnifyViewTest2EvenEven`	🖥️ Failed	— — VTK OpenGL render — fails without GPU
`ctkVTKMagnifyViewTest2OddEven`	🖥️ Failed	— — VTK OpenGL render — fails without GPU
`ctkVTKMagnifyViewTest2EvenOdd`	🖥️ Failed	— — VTK OpenGL render — fails without GPU
`ctkVTKTextPropertyWidgetEventTranslatorPlayerTest1`	🔄 Timeout	#1395 — Modal dialog timeout — addressed in test fix PR

Qt6 (10 failures):

Test	Status	Related PR/Issue
`CTKPluginFrameworkAppTests`	🐛 Subprocess aborted	— — Qt6 subprocess abort — pre-existing
`ctkLanguageComboBoxTest`	🔄 Failed	#1400 — BUG: Fix ctkLanguageComboBox locale normalization and selection
`ctkWidgetsUtilsTestGrabWidget`	🖥️ Failed	— — Requires OpenGL display — fails in headless environments
`ctkWorkflowWidgetTest1`	🐛 Failed	— — Qt6 QStateMachine async transitions — widgets not visible in time
`ctkWorkflowWidgetTest2`	🐛 Failed	— — Qt6 QStateMachine async transitions — widgets not visible in time
`vtkLightBoxRendererManagerTest1`	🖥️ SEGFAULT	— — GPU/GLSL infrastructure — SEGFAULT in headless environments
`ctkVTKMagnifyViewTest2OddOdd`	🖥️ Failed	— — VTK OpenGL render — fails without GPU
`ctkVTKMagnifyViewTest2EvenEven`	🖥️ Failed	— — VTK OpenGL render — fails without GPU
`ctkVTKMagnifyViewTest2OddEven`	🖥️ Failed	— — VTK OpenGL render — fails without GPU
`ctkVTKMagnifyViewTest2EvenOdd`	🖥️ Failed	— — VTK OpenGL render — fails without GPU

CTK Test Failures (reference 935c4e04)

Qt5 (25 failures):

Test	Status	Related PR/Issue
`ctkBackTraceTest`	🐛 Failed	— — Fixed on master — symbol resolution on Linux with hidden visibility
`ctkLoggerTest1`	🐛 Failed	— — Fixed on master — default log level expectation
`ctkFontButtonTest`	🔄 Timeout	#1395 — WIP: Fix ctkFontButtonTest hang and disable stale modal dialog tests
`ctkLanguageComboBoxTest`	🔄 Failed	#1400 — BUG: Fix ctkLanguageComboBox locale normalization and selection
`ctkMessageBoxDontShowAgainTest`	🐛 Failed	— — Fixed on master — ButtonRole vs StandardButton
`ctkWidgetsUtilsTestGrabWidget`	🖥️ Failed	— — Requires OpenGL display — fails in headless environments
`ctkColorPickerButtonEventTranslatorPlayerTest1`	🔄 Timeout	#1395 — Modal dialog timeout — addressed in test fix PR
`ctkDirectoryButtonEventTranslatorPlayerTest1`	🔄 Failed	#1395 — Modal dialog timeout — addressed in test fix PR
`ctkFileDialogEventTranslatorPlayerTest1`	🔄 Timeout	#1395 — Modal dialog timeout — addressed in test fix PR
`ctkMenuComboBoxEventTranslatorPlayerTest1`	🔄 Failed	#1395 — Modal dialog event translator failure
`ctkPathLineEditEventTranslatorPlayerTest1`	🐛 Failed	— — Fixed on master — XML widget name update
`ctkDICOMPatientDelegateTest1`	🐛 Failed	— — Fixed on master — default header height
`vtkLightBoxRendererManagerTest1`	🖥️ SEGFAULT	— — GPU/GLSL infrastructure — SEGFAULT in headless environments
`ctkVTKErrorLogModelFileLoggingTest1`	🐛 Failed	— — Fixed on master — Qt6 + line stability
`ctkVTKHistogramTest3`	🐛 Failed	— — Fixed on master — out-of-bounds read with signed VTK_CHAR
`ctkVTKPropertyWidgetTest`	🐛 Failed	— — Fixed on master — float precision comparison
`ctkVTKThresholdWidgetTest1`	🐛 Failed	— — Fixed on master — threshold lost after setRange
`ctkVTKSurfaceMaterialPropertyWidgetTest1`	🐛 Failed	— — Fixed on master — opacity comparison
`ctkVTKMagnifyViewTest2OddOdd`	🖥️ Failed	— — VTK OpenGL render — fails without GPU
`ctkVTKMagnifyViewTest2EvenEven`	🖥️ Failed	— — VTK OpenGL render — fails without GPU
`ctkVTKMagnifyViewTest2OddEven`	🖥️ Failed	— — VTK OpenGL render — fails without GPU
`ctkVTKMagnifyViewTest2EvenOdd`	🖥️ Failed	— — VTK OpenGL render — fails without GPU
`ctkVTKRenderViewEventTranslatorPlayerTest1`	🐛 Failed	— — Fixed on master — Qt6 protected operator=
`ctkVTKScalarBarWidgetEventTranslatorPlayerTest1`	🐛 Failed	— — Fixed on master — missing XML events
`ctkVTKTextPropertyWidgetEventTranslatorPlayerTest1`	🔄 Timeout	#1395 — Modal dialog timeout — addressed in test fix PR

Qt6 (10 failures):

Test	Status	Related PR/Issue
`CTKPluginFrameworkAppTests`	🐛 Subprocess aborted	— — Qt6 subprocess abort — pre-existing
`ctkLanguageComboBoxTest`	🔄 Failed	#1400 — BUG: Fix ctkLanguageComboBox locale normalization and selection
`ctkWidgetsUtilsTestGrabWidget`	🖥️ Failed	— — Requires OpenGL display — fails in headless environments
`ctkWorkflowWidgetTest1`	🐛 Failed	— — Qt6 QStateMachine async transitions — widgets not visible in time
`ctkWorkflowWidgetTest2`	🐛 Failed	— — Qt6 QStateMachine async transitions — widgets not visible in time
`vtkLightBoxRendererManagerTest1`	🖥️ SEGFAULT	— — GPU/GLSL infrastructure — SEGFAULT in headless environments
`ctkVTKMagnifyViewTest2OddOdd`	🖥️ Failed	— — VTK OpenGL render — fails without GPU
`ctkVTKMagnifyViewTest2EvenEven`	🖥️ Failed	— — VTK OpenGL render — fails without GPU
`ctkVTKMagnifyViewTest2OddEven`	🖥️ Failed	— — VTK OpenGL render — fails without GPU
`ctkVTKMagnifyViewTest2EvenOdd`	🖥️ Failed	— — VTK OpenGL render — fails without GPU

🔄 = addressed in open PR | 🖥️ = infrastructure/display dependent | 🐛 = known bug | ➖ = wontfix

Generated by /validate-ctk-pr skill | cache: /home/johnsonhj/src/CTK/.claude/validate-cache

hjmjohnson · 2026-04-03T17:04:00Z

@lassoan FYI: #1400 (comment) is a report that demostrates that building against Qt5, and Qt6 in stand-alone CTK builds, and building inside of Slicer introduce no new errors.

No new warnings from CTK source code itself. The 26 unused-variable warnings are addressed by the fix already prepared on PR #1409's branch. The old-style-cast warnings are from PythonQt/Python headers (external, not actionable).

setDefaultLanguage() stored the raw input string without validation or normalization. This caused two issues: 1. Bare language codes like "en" were not expanded to full locale codes (e.g. "en_US"), so defaultLanguage() returned "en" instead of the expected "en_US". 2. Invalid locale codes like "xx", "_en" were accepted instead of being rejected. Fix by normalizing the locale code through QLocale in setDefaultLanguage(). Codes that QLocale maps to "C" (unrecognized) are rejected and stored as empty. Also fix updateLanguageItems() to fall back to selecting the default language item when no prior selection exists, so currentLanguage() returns the correct value after the first setDefaultLanguage() call. Fixes ctkLanguageComboBoxTest on both Qt5 and Qt6.

hjmjohnson mentioned this pull request Mar 31, 2026

WIP: COMP: Clazy static analysis fixes : Many combined fixes needing to be separate PR's #1372

Closed

17 tasks

hjmjohnson marked this pull request as draft March 31, 2026 20:58

hjmjohnson force-pushed the fix-language-combobox branch from c87ab0a to 7c141e9 Compare April 1, 2026 13:14

hjmjohnson marked this pull request as ready for review April 1, 2026 13:14

jamesobutler requested a review from lassoan April 1, 2026 13:49

hjmjohnson force-pushed the fix-language-combobox branch from 7c141e9 to b6735e0 Compare April 1, 2026 19:48

hjmjohnson force-pushed the fix-language-combobox branch from b6735e0 to a708f38 Compare April 2, 2026 13:36

This was referenced Apr 3, 2026

COMP: Update CTK to latest (3b3f9eff) Slicer/Slicer#9097

Merged

STYLE: Replace non-POD ctkLogger globals with Q_GLOBAL_STATIC_WITH_ARGS #1409

Open

hjmjohnson force-pushed the fix-language-combobox branch 2 times, most recently from 56c899c to acf0e1b Compare April 9, 2026 02:01

hjmjohnson force-pushed the fix-language-combobox branch from acf0e1b to b1b175a Compare May 12, 2026 15:18

This was referenced May 19, 2026

BUG: Fix filter logic for compatibility between Qt5 and Qt6 #1421

Merged

BUG: Fix ctkMessageBox "Don't show again" not working in Qt6 #1420

Merged

hjmjohnson mentioned this pull request Jun 5, 2026

COMP: Update to find_package(Python3) #1250

Open

hjmjohnson force-pushed the fix-language-combobox branch from b1b175a to fd56552 Compare June 6, 2026 01:56

hjmjohnson force-pushed the fix-language-combobox branch from fd56552 to 2bf339d Compare August 31, 2026 14:25

Navigation Menu

Uh oh!

BUG: Fix ctkLanguageComboBox locale normalization and selection - #1400

BUG: Fix ctkLanguageComboBox locale normalization and selection#1400
hjmjohnson wants to merge 1 commit into
commontk:masterfrom
BRAINSia:fix-language-combobox

hjmjohnson commented Mar 31, 2026

Uh oh!

hjmjohnson commented Mar 31, 2026

Uh oh!

lassoan commented Apr 1, 2026

Uh oh!

hjmjohnson commented Apr 3, 2026 •

edited

Loading

Uh oh!

hjmjohnson commented Apr 3, 2026

Uh oh!

hjmjohnson commented Apr 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

hjmjohnson commented Mar 31, 2026

Summary

Test plan

Uh oh!

hjmjohnson commented Mar 31, 2026

Uh oh!

lassoan commented Apr 1, 2026

Uh oh!

hjmjohnson commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hjmjohnson commented Apr 3, 2026

CTK Validation Report for PR #1400

Validation Actions Performed

CTK-in-Slicer Build Detail (classified warnings)

Slicer Test Detail (classified failures)

Uh oh!

hjmjohnson commented Apr 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

hjmjohnson commented Apr 3, 2026 •

edited

Loading