BUG: Fix iterator invalidation in ctkCmdLineModuleCache::clearCache - #1396
Merged
lassoan merged 1 commit intoMar 30, 2026
Merged
Conversation
The foreach-to-for conversion in commontk#1383 introduced undefined behavior: removeCacheEntry() calls d->LocationToXmlDescription.remove(), which invalidates the iterators used by the enclosing for loop. The original foreach was safe because Qt's foreach macro copies the container before iterating. Restore that safety by iterating over a copy of the keys. The clazy container-anti-pattern warning is a false positive here — the copy is required for correctness. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lassoan
approved these changes
Mar 30, 2026
lassoan
left a comment
lassoan
left a comment
Member
There was a problem hiding this comment.
Thank you, it looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
foreach-to-forconversion in PERF/STYLE/BUG: Container fixes, signal cleanup, and Q_OBJECT macros (clazy) #1383removeCacheEntry()callsd->LocationToXmlDescription.remove(), which invalidates the iterators used by the enclosingforloopforeachwas safe because Qt'sforeachmacro copies the container before iterating.keys()The clazy
container-anti-patternwarning is a false positive here — the copy is required for correctness because the loop body mutates the container.Test plan
removeCacheEntry()modifies the iterated containerforeach-to-forconversions in PERF/STYLE/BUG: Container fixes, signal cleanup, and Q_OBJECT macros (clazy) #1383 — this is the only unsafe case🤖 Generated with Claude Code