Skip to content

build(openpilot): replace panda submodule with pip-distributed panda dependency #37908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adwit-agg wants to merge 4 commits into
base: master
Choose a base branch
from
Open

build(openpilot): replace panda submodule with pip-distributed panda dependency #37908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b74b848
build(openpilot): replace panda submodule with pip-distributed panda …
adwit-agg Apr 25, 2026
9d99977
fix dependency
adwit-agg Apr 25, 2026
9ad5fbd
changed variant dir to be under build folder as it is ignored by git.…
adwit-agg Apr 25, 2026
01e66c2
chore(ci): rerun workflow - unit test check failed due to unrelated e…
adwit-agg Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
[submodule "panda"]
path = panda
url = ../../commaai/panda.git
[submodule "opendbc"]
path = opendbc_repo
url = ../../commaai/opendbc.git
Expand Down
12 changes: 10 additions & 2 deletions SConstruct
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import platform
import shlex
import importlib
import numpy as np
import panda

import SCons.Errors
from SCons.Defaults import _stripixes
Expand Down Expand Up @@ -79,6 +80,10 @@ def _libflags(target, source, env, for_signature):
return _stripixes(env['LIBLINKPREFIX'], libs, env['LIBLINKSUFFIX'],
env['LIBPREFIXES'], env['LIBSUFFIXES'], env, env['LIBLITERALPREFIX'])

# dynamic path for panda
PANDA_DIR = os.path.dirname(panda.__file__)
SITE_PACKAGES_DIR = os.path.dirname(PANDA_DIR)

env = Environment(
ENV={
"PATH": os.environ['PATH'],
Expand Down Expand Up @@ -113,6 +118,8 @@ env = Environment(
"#third_party/acados/include/hpipm/include",
"#third_party/catch2/include",
[x.INCLUDE_DIR for x in pkgs],
PANDA_DIR,
SITE_PACKAGES_DIR,
],
LIBPATH=[
"#common",
Expand Down Expand Up @@ -227,8 +234,9 @@ messaging = [socketmaster, msgq, 'capnp', 'kj',]
Export('messaging')


# Build other submodules
SConscript(['panda/SConscript'])
# replaced hardcoded call to remove dependency on panda submodule
panda_sconscript = os.path.join(PANDA_DIR, 'SConscript')
SConscript(panda_sconscript, variant_dir='build/panda', duplicate=0)

# Build rednose library
SConscript(['rednose/SConscript'])
Expand Down
1 change: 0 additions & 1 deletion panda
Open in desktop
Submodule panda deleted from b19b66
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ dependencies = [
"aiortc",

# panda
"pandacan @ git+https://github.com/adwit-agg/panda.git@fix-pip-package",
"libusb1",
"spidev; platform_system == 'Linux'",

Expand Down
52 changes: 52 additions & 0 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading