Skip to content

chore: lint fixes part 9#261

Merged
pawbana merged 1 commit intomainfrom
pb/coder-lint-fix9
Apr 13, 2026
Merged

chore: lint fixes part 9#261
pawbana merged 1 commit intomainfrom
pb/coder-lint-fix9

Conversation

@pawbana
Copy link
Copy Markdown
Contributor

@pawbana pawbana commented Apr 10, 2026

  • testpackage (27 → 0): converted 7 test files to external test packages; exported GuessClient and GuessSessionID; merged two TestValidateProvider tests into one using NewRequestBridge; replaced
    bridge.mux.ServeHTTP with exported bridge.ServeHTTP; added //nolint:testpackage to 18 test files that heavily test unexported internals
  • noctx (12 → 0): replaced http.NewRequest with http.NewRequestWithContext(t.Context(), ...) in all test files
  • gocritic magic numbers (46 → 0): created internal/testutil/timeout.go with shared constants (WaitLong, WaitMedium, WaitShort, IntervalFast); replaced all magic timeout/interval values across 8 test files
  • gocritic slog.Error (2 → 0): pass .Error() string instead of error value as slog.F field
  • staticcheck SA9003 (1 → 0): added staticcheck to nolint directive on intentional empty recover
  • confusing-naming (1 → 0): renamed openErrorResponse() → openErrBody()
  • paralleltest (24 → 0): added t.Parallel() to top-level test functions and table-driven subtest loops
  • tparallel (4 → 0): added t.Parallel() to missing subtests

@pawbana pawbana marked this pull request as ready for review April 10, 2026 22:12
@pawbana pawbana force-pushed the pb/coder-lint-fix9 branch from e6ef1aa to 9edf045 Compare April 13, 2026 11:30
@pawbana pawbana force-pushed the pb/coder-lint-fix8 branch 2 times, most recently from 4bbf3fa to c449e19 Compare April 13, 2026 11:41
@pawbana pawbana force-pushed the pb/coder-lint-fix9 branch from 9edf045 to 2d8a18a Compare April 13, 2026 11:41
@pawbana pawbana force-pushed the pb/coder-lint-fix8 branch from c449e19 to a0dc36f Compare April 13, 2026 13:19
@pawbana pawbana force-pushed the pb/coder-lint-fix9 branch 2 times, most recently from 09d6738 to 8e41c92 Compare April 13, 2026 13:39
@pawbana pawbana force-pushed the pb/coder-lint-fix8 branch from a0dc36f to 24a6a2d Compare April 13, 2026 13:39
Copy link
Copy Markdown
Contributor Author

pawbana commented Apr 13, 2026

Merge activity

  • Apr 13, 3:10 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 13, 3:13 PM UTC: Graphite couldn't merge this pull request because a downstack PR chore: lint fixes part 1 (automatic fixes) #253 failed to merge.
  • Apr 13, 3:24 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 13, 3:40 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 13, 3:41 PM UTC: @pawbana merged this pull request with Graphite.

@pawbana pawbana force-pushed the pb/coder-lint-fix8 branch from 24a6a2d to d3a36de Compare April 13, 2026 15:22
@pawbana pawbana force-pushed the pb/coder-lint-fix9 branch from 8e41c92 to c64f123 Compare April 13, 2026 15:22
@pawbana pawbana changed the base branch from pb/coder-lint-fix8 to graphite-base/261 April 13, 2026 15:38
@pawbana pawbana changed the base branch from graphite-base/261 to main April 13, 2026 15:39
@pawbana pawbana force-pushed the pb/coder-lint-fix9 branch from c64f123 to c4950b0 Compare April 13, 2026 15:40
@pawbana pawbana merged commit 7fa8005 into main Apr 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants