Skip to content

chore: lint fixes part 4#256

Merged
pawbana merged 2 commits intomainfrom
pb/coder-lint-fix4
Apr 13, 2026
Merged

chore: lint fixes part 4#256
pawbana merged 2 commits intomainfrom
pb/coder-lint-fix4

Conversation

@pawbana
Copy link
Copy Markdown
Contributor

@pawbana pawbana commented Apr 10, 2026 •
edited
Loading

  • import-shadowing (11): renamed recorder parameter to rec in Setup() interface + all 9 implementations to avoid shadowing the recorder package import; renamed provider parameter to prov in
    newPassthroughRouter to avoid shadowing the provider package
  • unused-receiver (1): omitted receiver name on AsyncRecorder.RecordInterception panic method
  • context-as-argument (2): moved context.Context to first parameter in newBridgeTestServer and newMockUpstream, updated ~60 call sites
  • G306/gosec (2): tightened WriteFile permissions from 0o644 to 0o600 in API dump files
  • forcetypeassert (2): added nolint directives for sync.Map type assertions in circuit breaker (always stores the same type)

This was referenced Apr 10, 2026
Merged
Merged
Merged
@pawbana Graphite App
Copy link
Copy Markdown
Contributor Author

pawbana commented Apr 10, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Apr 10, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@pawbana pawbana marked this pull request as ready for review April 10, 2026 22:12
@pawbana pawbana mentioned this pull request Apr 13, 2026
Merged
dannykopping
dannykopping reviewed Apr 13, 2026
View reviewed changes
internal/integrationtest/setupbridge.go
func newBridgeTestServer(
t *testing.T,
ctx context.Context,
t *testing.T,
Copy link
Copy Markdown
Collaborator

@dannykopping dannykopping Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this picked up by a linter? Seems like an unneccesary change.

Copy link
Copy Markdown
Contributor Author

@pawbana pawbana Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it this regarding this point:

context-as-argument (2): moved context.Context to first parameter in newBridgeTestServer and newMockUpstream, updated ~60 call sites

linter rule is that context needs to be first argument IIRC.

Copy link
Copy Markdown
Collaborator

@dannykopping dannykopping Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK 👍

@pawbana pawbana force-pushed the pb/coder-lint-fix4 branch from edd1f90 to e1765bc Compare April 13, 2026 11:30
@pawbana pawbana force-pushed the pb/coder-lint-fix3 branch from ead0336 to e63a56f Compare April 13, 2026 11:30
@pawbana Graphite App
Copy link
Copy Markdown
Contributor Author

pawbana commented Apr 13, 2026 •
edited
Loading

Merge activity

  • Apr 13, 3:10 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 13, 3:13 PM UTC: Graphite couldn't merge this pull request because a downstack PR chore: lint fixes part 1 (automatic fixes) #253 failed to merge.
  • Apr 13, 3:24 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 13, 3:30 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 13, 3:31 PM UTC: @pawbana merged this pull request with Graphite.

@pawbana pawbana force-pushed the pb/coder-lint-fix3 branch from e63a56f to 872a966 Compare April 13, 2026 15:22
@pawbana pawbana force-pushed the pb/coder-lint-fix4 branch from e7bd5a3 to 3a516ee Compare April 13, 2026 15:22
@pawbana pawbana changed the base branch from pb/coder-lint-fix3 to graphite-base/256 April 13, 2026 15:27
@pawbana pawbana changed the base branch from graphite-base/256 to main April 13, 2026 15:29
@pawbana pawbana force-pushed the pb/coder-lint-fix4 branch from 3a516ee to d553061 Compare April 13, 2026 15:30
@pawbana pawbana merged commit 94b4a1b into main Apr 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dannykopping dannykopping dannykopping approved these changes

@ssncferreira ssncferreira Awaiting requested review from ssncferreira

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pawbana @dannykopping