Skip to content

fix(PRLT-1370): isClaudeExecutor accepts legacy 'claude' value #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrismcdermut wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(PRLT-1370): isClaudeExecutor accepts legacy 'claude' value #1259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/cli/src/lib/execution/runners/executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,13 @@ export function getExecutorCommand(executor: ExecutorType, prompt: string, skipP

/**
* Check if an executor is Claude Code.
*
* Accepts both 'claude-code' (current canonical value) and 'claude' (legacy
* value seeded by migration 0023 into workspace_settings.execution.default_executor).
* Without this, the credential bind mount is skipped for workspaces seeded with 'claude'.
*/
export function isClaudeExecutor(executor: ExecutorType): boolean {
return executor === 'claude-code'
return executor === 'claude-code' || (executor as string) === 'claude'
}

/**
Expand Down
6 changes: 6 additions & 0 deletions apps/cli/test/unit/execution-utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,12 @@ describe('Execution Utils', () => {
expect(isClaudeExecutor('claude-code')).to.be.true
})

it('should return true for legacy claude value (PRLT-1370)', () => {
// Migration 0023 seeds workspace_settings with 'claude', so the credential
// mount must still be applied when the DB returns this legacy value.
expect(isClaudeExecutor('claude' as ExecutorType)).to.be.true
})

it('should return false for codex', () => {
expect(isClaudeExecutor('codex')).to.be.false
})
Expand Down
Loading