fix(PRLT-1370): isClaudeExecutor accepts legacy 'claude' value#1259
Open
chrismcdermut wants to merge 1 commit into
Open
fix(PRLT-1370): isClaudeExecutor accepts legacy 'claude' value#1259chrismcdermut wants to merge 1 commit into
chrismcdermut wants to merge 1 commit into
Conversation
…ude' value so credential mount applies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workspace_settings.execution.default_executoris seeded as'claude'by migration 0023, butisClaudeExecutor()only matched'claude-code'. This causedbuildContainerMounts()to skip the credential bind mount in Docker agents, leaving them unable to authenticate.Fix
isClaudeExecutor()now also returnstruefor the legacy'claude'value. The cast keeps the function compatible with the strictExecutorTypeunion while accepting the runtime value the DB actually holds.Test plan
execution-utils.test.tsassertingisClaudeExecutor('claude')returnstrueisClaudeExecutortests still passpnpm buildcleanLinear: PRLT-1370